FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: add `added:` information for v8 by Trott · Pull Request #6684 · nodejs/node · GitHub

/ node Public

doc: add added: information for v8 - #6684

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:v8
ConversationCommits (1)ChecksFiles changed
Closed

doc: add added: information for v8#6684
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:v8

Conversation

Trott commented May 11, 2016

Copy link
Copy Markdown
Member
Checklist
  • tests and code linting passes
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)

doc v8

Description of change

Trott added doc Issues and PRs related to the documentations. v8 engine Issues and PRs related to the V8 dependency. labels May 11, 2016
sam-github mentioned this pull request May 11, 2016
Closed
36 tasks

bnoordhuis commented May 11, 2016

Copy link
Copy Markdown
Member

LGTM

2 similar comments

claudiorodriguez commented May 11, 2016

Copy link
Copy Markdown
Contributor

LGTM

Qard commented May 11, 2016

Copy link
Copy Markdown
Member

LGTM

addaleax commented May 12, 2016

Copy link
Copy Markdown
Member

LGTM but it may be nice to have the Ref: field as in the other commit messages, if only for consistency :)

Trott commented May 12, 2016

Copy link
Copy Markdown
Member Author

Ref: added, rebased, force pushed.

Trott commented May 12, 2016

Copy link
Copy Markdown
Member Author

And just to have the Ref here:

Ref: #6578

Trott commented May 13, 2016

Copy link
Copy Markdown
Member Author

Doc-only change, but exercising caution anyway: https://ci.nodejs.org/job/node-test-pull-request/2618/

Trott commented May 13, 2016

Copy link
Copy Markdown
Member Author

Only CI failure was a buildbot failure. Landing...

Trott added a commit to Trott/io.js that referenced this pull request May 13, 2016
doc: add added: information for v8
b3bc362 
PR-URL: nodejs#6684
Ref: nodejs#6578
Reviewed-By: Ben Noorhduis <info@bnoordhuis.nl>
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

Trott commented May 13, 2016

Copy link
Copy Markdown
Member Author

Landed in b3bc362

Trott closed this May 13, 2016
evanlucas pushed a commit that referenced this pull request May 17, 2016
doc: add added: information for v8
f1c773d 
PR-URL: #6684
Ref: #6578
Reviewed-By: Ben Noorhduis <info@bnoordhuis.nl>
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
evanlucas mentioned this pull request May 17, 2016
Merged
addaleax pushed a commit to addaleax/node that referenced this pull request Jul 12, 2016
doc: add added: information for v8
e5392f0 
PR-URL: nodejs#6684
Ref: nodejs#6578
Reviewed-By: Ben Noorhduis <info@bnoordhuis.nl>
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
doc: add added: information for v8
effe930 
PR-URL: #6684
Ref: #6578
Reviewed-By: Ben Noorhduis <info@bnoordhuis.nl>
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
doc: add added: information for v8
9f32a1c 
PR-URL: #6684
Ref: #6578
Reviewed-By: Ben Noorhduis <info@bnoordhuis.nl>
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins mentioned this pull request Jul 12, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
doc: add added: information for v8
02af985 
PR-URL: #6684
Ref: #6578
Reviewed-By: Ben Noorhduis <info@bnoordhuis.nl>
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
doc: add added: information for v8
3e3471f 
PR-URL: #6684
Ref: #6578
Reviewed-By: Ben Noorhduis <info@bnoordhuis.nl>
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Trott deleted the v8 branch January 13, 2022 22:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL