FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

tools: enforce linting for unix-style line endings by Trott · Pull Request #6685 · nodejs/node · GitHub

/ node Public

tools: enforce linting for unix-style line endings - #6685

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:rn
ConversationCommits (1)ChecksFiles changed
Closed

tools: enforce linting for unix-style line endings#6685
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:rn

Conversation

Trott commented May 11, 2016

Copy link
Copy Markdown
Member
Checklist
  • tests and code linting passes
  • the commit message follows commit guidelines
Affected core subsystem(s)

tools

Description of change

Trott added the tools Issues and PRs related to the tools directory. label May 11, 2016

targos commented May 11, 2016

Copy link
Copy Markdown
Member

LGTM

1 similar comment

jbergstroem commented May 11, 2016

Copy link
Copy Markdown
Member

LGTM

bnoordhuis reviewed May 11, 2016
View reviewed changes
Comment thread .eslintrc Outdated

bnoordhuis May 11, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Just curious, isn't it normally written as linebreak-style: "unix"?

silverwind May 11, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

It should actually be linebreak-style: [2, "unix"].

Trott May 11, 2016

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

"unix" is the default so just enabling it with 2 is enough. However, if explicitness is desired, I'm happy to change it to [2, "unix"].

silverwind May 11, 2016 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Yes, please be explicit. If they ever change the default, we'd be screwed. 😆

Also, it's easier to understand for someone unfamiliar with ESLint's defaults.

Trott May 11, 2016

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Edited to be explicit about the unix option, rebased, force pushed.

jasnell commented May 11, 2016

Copy link
Copy Markdown
Member

LGTM

silverwind commented May 11, 2016

Copy link
Copy Markdown
Contributor

LGTM once #6685 (comment) is addressed.

bnoordhuis commented May 11, 2016

Copy link
Copy Markdown
Member

LGTM

Trott commented May 13, 2016

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/2620/

Trott commented May 13, 2016

Copy link
Copy Markdown
Member Author

Two CI failures are a known flaky and a buildbot failure. Landing...

Trott added a commit to Trott/io.js that referenced this pull request May 13, 2016
tools: enforce linting for unix-style line endings
517b892 
PR-URL: nodejs#6685
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Ben Noorhduis <info@bnoordhuis.nl>

Trott commented May 13, 2016

Copy link
Copy Markdown
Member Author

Landed in 517b892

Trott closed this May 13, 2016
evanlucas pushed a commit that referenced this pull request May 17, 2016
tools: enforce linting for unix-style line endings
347abf3 
PR-URL: #6685
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Ben Noorhduis <info@bnoordhuis.nl>
evanlucas mentioned this pull request May 17, 2016
Merged
This was referenced May 23, 2016
Closed
Closed
Trott deleted the rn branch January 13, 2022 22:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL