FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: make the documentation print-friendly by sorcamarian · Pull Request #6748 · nodejs/node · GitHub

/ node Public

doc: make the documentation print-friendly - #6748

Closed
sorcamarian wants to merge 1 commit into
nodejs:masterfrom
sorcamarian:master
Closed

doc: make the documentation print-friendly#6748
sorcamarian wants to merge 1 commit into
nodejs:masterfrom
sorcamarian:master

Conversation

sorcamarian commented May 13, 2016
edited
Loading

Copy link
Copy Markdown
Checklist
  • tests and code linting passes
  • a test and/or benchmark is included
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)
Description of change

nodejs-github-bot added the doc Issues and PRs related to the documentations. label May 13, 2016

Qard commented May 13, 2016
edited
Loading

Copy link
Copy Markdown
Member

LGTM, but please add doc: to the start of the commit message.

sorcamarian changed the title Make the documentation print-friendly doc: Make the documentation print-friendly May 13, 2016

Qard commented May 13, 2016

Copy link
Copy Markdown
Member

Sorry, I meant the commit itself, not just the PR. You'll need to do a git commit --amend to edit the commit message, then force push the modified commit.

Copy link
Copy Markdown
Contributor

/cc @nodejs/website

Copy link
Copy Markdown
Author

@Qard I did --ammend, and --force push
Please make a check

Comment thread doc/api_assets/style.css Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Nit: missing newline at the end of file.

Copy link
Copy Markdown
Author

@ChALkeR I updated the commit.

Comment thread doc/api_assets/style.css Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

New line still missing here.

lpinca commented May 14, 2016

Copy link
Copy Markdown
Member

Please edit the commit message while you are at it: Make -> make.

Comment thread doc/api_assets/style.css Outdated

ChALkeR May 14, 2016
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Replace

  html  {

with

  html {

as I noted above (one space between html and { instead of two).

Copy link
Copy Markdown
Author

White spaces removed.

Copy link
Copy Markdown
Author

Has something remained?

Copy link
Copy Markdown
Member

@sorcamarian I think this is good to go. Like @lpinca said in his last comment, the commit message subject should be all-lowercase, but things like this can be taken of when landing the commit.

If you’re asking why this isn’t merged yet, it’s just that it’s customary to wait a bit (72 hours over weekends is a general rule) before merging so that everyone has a chance to look at it.

I’d suggest you additionally use Fixes: https://github.com/nodejs/node/issues/6743 instead of the more info line, because then the issue will be closed automatically when your commit is landed.

Also: You author name in this commit is given as “Marian”. Is that intended or do you prefer to be listed (changelog, git log, AUTHORS file) with some other name? People typically prefer their full name, but ultimately it’s up to you.

sorcamarian changed the title doc: Make the documentation print-friendly doc: make the documentation print-friendly May 16, 2016

Copy link
Copy Markdown
Author

@addaleax Thanks for the given explanations.

I'm fine with the current name("Marian").

Copy link
Copy Markdown
Contributor

LGTM... minor nits regarding newlines + commit message can be fixed when landing

Would like to hear something from more folks from @nodejs/documentation and @nodejs/website

MylesBorins self-assigned this May 16, 2016

lpinca commented May 16, 2016
edited
Loading

Copy link
Copy Markdown
Member

All nits seem to be fixed.

Copy link
Copy Markdown
Member

LGTM

Copy link
Copy Markdown
Author

Any news?

eljefedelrodeodeljefe pushed a commit that referenced this pull request May 23, 2016
Fixes: #6743

PR-URL: #6748
Reviewed-By: Robert Jefe Lindstaedt <robert.lindstaedt@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>

Copy link
Copy Markdown
Contributor

Landed in c161849. Thanks!

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Node.js documentation is not print-friendly

9 participants


Back | FazBrowse Home | New Git URL