doc: buffers are not sent over IPC with a socket - #6951
Closed
timkuijsten wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Comment thread
doc/api/child_process.md
Outdated
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
This sentence seems incomplete. I would just stop after "will not be sent to the child." and remove the rest.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
One comment, but LGTM. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
updated + added a new finding while trying to work around the issue myself. |
Sorry, something went wrong.
Comment thread
doc/api/child_process.md
Outdated
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Have you seen the keepOpen option to send()?
Sorry, something went wrong.
If a socket is sent to a child, any data that is buffered in the socket will not be sent to the child. The child will only receive data from the socket that is sent after the child has the socket.
Copy link
Copy Markdown
Contributor
Author
|
No I had not, tnx! Updated the diff. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
LGTM, landing this… |
Sorry, something went wrong.
addaleax
pushed a commit
that referenced
this pull request
May 29, 2016
If a socket is sent to a child, any data that is buffered in the socket will not be sent to the child. The child will only receive data from the socket that is sent after the child has the socket. PR-URL: #6951 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Fishrock123
pushed a commit
to Fishrock123/node
that referenced
this pull request
May 30, 2016
If a socket is sent to a child, any data that is buffered in the socket will not be sent to the child. The child will only receive data from the socket that is sent after the child has the socket. PR-URL: nodejs#6951 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
rvagg
pushed a commit
that referenced
this pull request
Jun 2, 2016
If a socket is sent to a child, any data that is buffered in the socket will not be sent to the child. The child will only receive data from the socket that is sent after the child has the socket. PR-URL: #6951 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Copy link
Copy Markdown
Contributor
|
this is not landing cleanly, and I'm not 100% it applies to v4.x Please backport if neccessary |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
It does apply to v4.x as well: $ node --version
v4.4.7$ cat m.js
const fork = require('child_process').fork
const net = require('net')
const cp = fork('./child.js')
net.createServer(c => {
setTimeout(() => {
cp.send({}, c)
}, 500) // send the connection after a delay
}).listen(1234, () => {
net.createConnection(1234, function() {
var i = 0
setInterval(() => {
this.write(`${i++} `)
}, 100) // start sending data before the connection is sent to the child
})
})$ cat child.js
process.on('message', (m, c) => {
console.log('child: got connection')
c.pipe(process.stdout)
})$ node m.js
child: got connection
4 5 6 7 8 ^C |
Sorry, something went wrong.
This was referenced Jul 12, 2016
Closed
MylesBorins
pushed a commit
that referenced
this pull request
Jul 12, 2016
If a socket is sent to a child, any data that is buffered in the socket will not be sent to the child. The child will only receive data from the socket that is sent after the child has the socket. PR-URL: #6951 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins
pushed a commit
that referenced
this pull request
Jul 12, 2016
If a socket is sent to a child, any data that is buffered in the socket will not be sent to the child. The child will only receive data from the socket that is sent after the child has the socket. PR-URL: #6951 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Jul 14, 2016
If a socket is sent to a child, any data that is buffered in the socket will not be sent to the child. The child will only receive data from the socket that is sent after the child has the socket. PR-URL: #6951 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins
pushed a commit
that referenced
this pull request
Jul 14, 2016
If a socket is sent to a child, any data that is buffered in the socket will not be sent to the child. The child will only receive data from the socket that is sent after the child has the socket. PR-URL: #6951 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc/child_process
Description of change
If a socket is sent to a child, any data that is buffered in the
socket will not be sent to the child. The child will only receive
data from the socket that is sent after the child has the socket.