Backport 6907 to v4.x (console.* not working when running out of stack space) - #6957
Closed
addaleax wants to merge 4 commits into
Closed
Backport 6907 to v4.x (console.* not working when running out of stack space)#6957addaleax wants to merge 4 commits into
addaleax wants to merge 4 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
Correct alignment on variable assignments that span multiple lines in preparation for lint rule to enforce such alignment. PR-URL: nodejs#6869 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
Enforce alignment/indentation on variable assignments that span multiple lines. PR-URL: nodejs#6869 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
Copy link
Copy Markdown
Member
|
Are the two commits from @Trott necessary for this? At first glance those don't appear to be related but I could be missing something. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
@nodejs/lts |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Make less assumptions about what objects will be available when vm context creation or error message printing fail because V8 runs out of JS stack space. Ref: nodejs#6899
Don't cache the exported values of fully uninitialized builtins. This works by adding an additional `loading` flag that is only active during initial loading of an internal module and checking that either the module is fully loaded or is in that state before using its cached value. This has the effect that builtins modules which could not be loaded (e.g. because compilation failed due to missing stack space) can be loaded at a later point. Fixes: nodejs#6899
3 tasks
MylesBorins
force-pushed
the
v4.x-staging
branch
3 times, most recently
from
ed3d372 to
f14d9cf
Compare
June 28, 2016 22:49
Copy link
Copy Markdown
Contributor
|
landed in 395f4be...5ba807a |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
vm, module
Description of change
Backport of #6907 to v4.x