FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: add `added: ` data for cli.md by Trott · Pull Request #6960 · nodejs/node · GitHub

/ node Public

doc: add added: data for cli.md - #6960

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:cli-added
ConversationCommits (1)ChecksFiles changed
Closed

doc: add added: data for cli.md#6960
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:cli-added

Conversation

Trott commented May 25, 2016

Copy link
Copy Markdown
Member
Checklist
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

Added YAML info to cli.md. (Also removed one unnecessary word from the text because it was bugging me.)

Refs: #6578

Trott added the doc Issues and PRs related to the documentations. label May 25, 2016
sam-github mentioned this pull request May 25, 2016
Closed
36 tasks
Fishrock123 reviewed May 25, 2016
View reviewed changes
Comment thread doc/api/cli.md

### `--tls-cipher-list=list`
<!-- YAML
added: v4.0.0

Fishrock123 May 25, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Didn't this get backported or something?

Trott May 25, 2016

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

It looks like that may have been in 0.12 or whatever, but it wasn't in any of the io.js releases, so... I don't know, I think it reduces confusion if we say 4.0.0. Otherwise people need the historic knowledge that 1.0.0-3.x.x are special. I'd prefer to assume people don't know that.

jasnell May 25, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Yes, this originally landed in v0.12 and did not come into any of the io.js streams. It landed in v4 as part of the convergence.

Trott May 25, 2016

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I think that means that 4.0.0 is the right version to go with in the YAML comment. Does anyone disagree? /cc @addaleax @bengl @sam-github

addaleax May 25, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@Trott +1 for keeping it as 4.0.0… the doctool would support adding multiple versions here, but I implemented that more with LTS backports in mind, and I think adding some 0.12.x here would be more confusing than helping.

Fishrock123 commented May 25, 2016

Copy link
Copy Markdown
Contributor

lgtm minus the nit

jasnell commented May 25, 2016

Copy link
Copy Markdown
Member

Generally LGTM

MylesBorins commented May 26, 2016

Copy link
Copy Markdown
Contributor

LGTM

Trott added a commit to Trott/io.js that referenced this pull request May 27, 2016
doc: add added: data for cli.md
9067581 
PR-URL: nodejs#6960
Refs: nodejs#6578
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>

Trott commented May 27, 2016

Copy link
Copy Markdown
Member Author

Landed in 9067581

Trott closed this May 27, 2016
Fishrock123 pushed a commit to Fishrock123/node that referenced this pull request May 30, 2016
doc: add added: data for cli.md
3cee0a2 
PR-URL: nodejs#6960
Refs: nodejs#6578
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
rvagg pushed a commit that referenced this pull request Jun 2, 2016
doc: add added: data for cli.md
bc2efe2 
PR-URL: #6960
Refs: #6578
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
MylesBorins mentioned this pull request Jul 11, 2016
Closed
addaleax pushed a commit to addaleax/node that referenced this pull request Jul 12, 2016
doc: add added: data for cli.md
3391fc7 
PR-URL: nodejs#6960
Refs: nodejs#6578
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
doc: add added: data for cli.md
d09c396 
PR-URL: #6960
Refs: #6578
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
doc: add added: data for cli.md
708ce6c 
PR-URL: #6960
Refs: #6578
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
MylesBorins mentioned this pull request Jul 12, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
doc: add added: data for cli.md
7138a42 
PR-URL: #6960
Refs: #6578
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
doc: add added: data for cli.md
eb08c17 
PR-URL: #6960
Refs: #6578
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Trott deleted the cli-added branch January 13, 2022 22:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL