| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
Replaced deprecated util._extend with Object.assign per [documentation](https://nodejs.org/api/util.html#util_util_extend_obj)
|
I don't think the deprecation was really intended for node core as much as it was for userland. See the original discussion here. One of the reasons is that Object.assign() is/was slower. The changes would need to be benchmarked first before this PR would be landed, to see if it is still slower and by how much. |
Sorry, something went wrong.
|
quick & dirty benchmarking shows that Object.assign({}, process.env) is still about 50 % slower for me than util._extend({}, process.env), so yes, this PR would probably not improve things performance-wise. |
Sorry, something went wrong.
|
I'm going to close this for now. We can revisit when performance of Object.assign() improves, or if it is used in a way that makes it a better option than util._extend(). |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Checklist
Affected core subsystem(s)
Description of change
Replaced deprecated util._extend with Object.assign per documentation