FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Remove deprecated function by zwhitchcox · Pull Request #6977 · nodejs/node · GitHub

/ node Public

Remove deprecated function - #6977

Closed
zwhitchcox wants to merge 1 commit into
nodejs:masterfrom
zwhitchcox:patch-1
Closed

Remove deprecated function#6977
zwhitchcox wants to merge 1 commit into
nodejs:masterfrom
zwhitchcox:patch-1

Conversation

zwhitchcox commented May 25, 2016
edited by imran-iq
Loading

Copy link
Copy Markdown
Checklist
  • tests and code linting passes
  • a test and/or benchmark is included
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)
Description of change

Replaced deprecated util._extend with Object.assign per documentation

Replaced deprecated util._extend with Object.assign per [documentation](https://nodejs.org/api/util.html#util_util_extend_obj)
nodejs-github-bot added the cluster Issues and PRs related to the cluster subsystem. label May 25, 2016

mscdex commented May 25, 2016

Copy link
Copy Markdown
Contributor

I don't think the deprecation was really intended for node core as much as it was for userland. See the original discussion here. One of the reasons is that Object.assign() is/was slower. The changes would need to be benchmarked first before this PR would be landed, to see if it is still slower and by how much.

Copy link
Copy Markdown
Member

quick & dirty benchmarking shows that Object.assign({}, process.env) is still about 50 % slower for me than util._extend({}, process.env), so yes, this PR would probably not improve things performance-wise.

cjihrig commented Jun 1, 2016

Copy link
Copy Markdown
Contributor

I'm going to close this for now. We can revisit when performance of Object.assign() improves, or if it is used in a way that makes it a better option than util._extend().

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cluster Issues and PRs related to the cluster subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL