FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: remove modifcation to common.PORT by Trott · Pull Request #6990 · nodejs/node · GitHub

/ node Public

test: remove modifcation to common.PORT - #6990

Closed
Trott wants to merge 2 commits into
nodejs:masterfrom
Trott:no-plus
ConversationCommits (2)ChecksFiles changed
Closed

test: remove modifcation to common.PORT#6990
Trott wants to merge 2 commits into
nodejs:masterfrom
Trott:no-plus

Conversation

Trott commented May 26, 2016

Copy link
Copy Markdown
Member
Checklist
  • tests and code linting passes
  • the commit message follows commit guidelines
Affected core subsystem(s)

test debugger

Description of change

A possibly-buggy fixture server uses common.PORT+1000 for its port
rather than common.PORT. That could result in it clashing with other
ports if tests are run in parallel. The test runner increments
common.PORT by 100 for each running instance for tests. Change to use
common.PORT and have the tests that use the fixture start with
common.PORT+1 for anything they need.

Refs: #6989

test: remove modifcation to common.PORT
46ae822 
A possibly-buggy fixture server uses `common.PORT+1000` for its port
rather than `common.PORT`. That could result in it clashing with other
ports if tests are run in parallel. The test runner increments
`common.PORT` by 100 for each running instance for tests. Change to use
common.PORT and have the tests that use the fixture start with
common.PORT+1 for anything they need.

Refs: nodejs#6989
Trott added debugger test Issues and PRs related to the tests. labels May 26, 2016

Trott commented May 26, 2016

Copy link
Copy Markdown
Member Author

/cc @rvagg

MylesBorins commented May 26, 2016

Copy link
Copy Markdown
Contributor

@Trott LGTM

It seems like there are a few other instances... specifically in the debugger tests... would you be open to changing all of these instances in this PR?

bnoordhuis commented May 26, 2016

Copy link
Copy Markdown
Member

My grep fu finds these:

$ git grep -P 'PORT\s*\+\s*\d\d+' test/
test/debugger/helper-debugger-repl.js:var port = common.PORT + 1337;
test/debugger/test-debugger-client.js:var debugPort = common.PORT + 1337;
test/fixtures/clustered-server/app.js:  server.listen(common.PORT+1000);
test/parallel/test-debug-signal-cluster.js:var port = common.PORT + 42;

There are several more that add a single digit number but those look Mostly Harmless.

The changes in this PR LGTM although comments should preferably be capitalized and punctuated and have two spaces before the //.

santigimeno commented May 26, 2016

Copy link
Copy Markdown
Member

LGTM

mscdex commented May 26, 2016 •
edited
Loading

Copy link
Copy Markdown
Contributor

Why not take this opportunity to just use 0 for the port and let the OS assign one? Death to common.PORT!

cjihrig commented May 26, 2016

Copy link
Copy Markdown
Contributor

LGTM

Trott commented May 26, 2016

Copy link
Copy Markdown
Member Author

Why not take this opportunity to just use 0 for the port and let the OS assign one? Death to common.PORT!

If that works, that would also solve the problem where one test doesn't clean up after itself and subsequent tests start getting EADDRINUSE errors.

bnoordhuis commented May 26, 2016

Copy link
Copy Markdown
Member

That won't work for debugger tests until #5025 lands. Dusting off that PR is on my TODO list, though.

mhdawson commented May 27, 2016

Copy link
Copy Markdown
Member

LGTM

Fishrock123 reviewed May 27, 2016
View reviewed changes
Comment thread test/parallel/test-debug-port-cluster.js Outdated
const spawn = require('child_process').spawn;

const PORT_MIN = common.PORT;
const PORT_MIN = common.PORT + 1; // fixture uses common.PORT

Fishrock123 May 27, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Would be less confusing to assign to a special port in fixtures?

Trott May 28, 2016

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I thought so too at first, but it turns out that the fixture uses a single port, while this uses use multiple ports. Less weird IMO to give the common.PORT to the fixture and let this use special ports rather than have both using special ports and needing to make sure that the special ports don't collide.

Trott commented May 28, 2016

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/2842/

Trott commented May 29, 2016

Copy link
Copy Markdown
Member Author

CI again, although fail on Raspberry Pi is certainly unrelated: https://ci.nodejs.org/job/node-test-pull-request/2843/

Trott added a commit to Trott/io.js that referenced this pull request May 29, 2016
test: remove modifcation to common.PORT
bddfe63 
A possibly-buggy fixture server uses `common.PORT+1000` for its port
rather than `common.PORT`. That could result in it clashing with other
ports if tests are run in parallel. The test runner increments
`common.PORT` by 100 for each running instance for tests. Change to use
common.PORT and have the tests that use the fixture start with
common.PORT+1 for anything they need.

PR-URL: nodejs#6990
Refs: nodejs#6989
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

Trott commented May 29, 2016

Copy link
Copy Markdown
Member Author

Landed in bddfe63

@thealphanerd @bnoordhuis I'll pick off the remaining instances in a subsequent PR.

Trott closed this May 29, 2016
Trott added a commit to Trott/io.js that referenced this pull request May 29, 2016
test: remove non-incremental common.PORT changes
9122028 
Remove uses of `common.PORT + 1337` where `common.PORT` suffices.

Refs: nodejs#6990
Trott mentioned this pull request May 29, 2016
Closed
2 tasks
Fishrock123 pushed a commit to Fishrock123/node that referenced this pull request May 30, 2016
test: remove modifcation to common.PORT
4e826f4 
A possibly-buggy fixture server uses `common.PORT+1000` for its port
rather than `common.PORT`. That could result in it clashing with other
ports if tests are run in parallel. The test runner increments
`common.PORT` by 100 for each running instance for tests. Change to use
common.PORT and have the tests that use the fixture start with
common.PORT+1 for anything they need.

PR-URL: nodejs#6990
Refs: nodejs#6989
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Trott added a commit to Trott/io.js that referenced this pull request Jun 2, 2016
test: remove non-incremental common.PORT changes
85da963 
Remove uses of `common.PORT + 1337` where `common.PORT` suffices.

PR-URL: nodejs#7055
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Refs: nodejs#6990
rvagg pushed a commit that referenced this pull request Jun 2, 2016
test: remove modifcation to common.PORT
0a258e5 
A possibly-buggy fixture server uses `common.PORT+1000` for its port
rather than `common.PORT`. That could result in it clashing with other
ports if tests are run in parallel. The test runner increments
`common.PORT` by 100 for each running instance for tests. Change to use
common.PORT and have the tests that use the fixture start with
common.PORT+1 for anything they need.

PR-URL: #6990
Refs: #6989
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
rvagg pushed a commit that referenced this pull request Jun 2, 2016
test: remove non-incremental common.PORT changes
8b720c4 
Remove uses of `common.PORT + 1337` where `common.PORT` suffices.

PR-URL: #7055
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Refs: #6990
MylesBorins mentioned this pull request Jul 11, 2016
Closed
MylesBorins pushed a commit that referenced this pull request Jul 11, 2016
test: remove modifcation to common.PORT
182a609 
A possibly-buggy fixture server uses `common.PORT+1000` for its port
rather than `common.PORT`. That could result in it clashing with other
ports if tests are run in parallel. The test runner increments
`common.PORT` by 100 for each running instance for tests. Change to use
common.PORT and have the tests that use the fixture start with
common.PORT+1 for anything they need.

PR-URL: #6990
Refs: #6989
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins pushed a commit that referenced this pull request Jul 11, 2016
test: remove non-incremental common.PORT changes
97e651d 
Remove uses of `common.PORT + 1337` where `common.PORT` suffices.

PR-URL: #7055
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Refs: #6990
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
test: remove modifcation to common.PORT
ed586ec 
A possibly-buggy fixture server uses `common.PORT+1000` for its port
rather than `common.PORT`. That could result in it clashing with other
ports if tests are run in parallel. The test runner increments
`common.PORT` by 100 for each running instance for tests. Change to use
common.PORT and have the tests that use the fixture start with
common.PORT+1 for anything they need.

PR-URL: #6990
Refs: #6989
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
test: remove non-incremental common.PORT changes
ef8cb6a 
Remove uses of `common.PORT + 1337` where `common.PORT` suffices.

PR-URL: #7055
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Refs: #6990
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
test: remove modifcation to common.PORT
cd99a3e 
A possibly-buggy fixture server uses `common.PORT+1000` for its port
rather than `common.PORT`. That could result in it clashing with other
ports if tests are run in parallel. The test runner increments
`common.PORT` by 100 for each running instance for tests. Change to use
common.PORT and have the tests that use the fixture start with
common.PORT+1 for anything they need.

PR-URL: #6990
Refs: #6989
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
test: remove non-incremental common.PORT changes
ff9fedc 
Remove uses of `common.PORT + 1337` where `common.PORT` suffices.

PR-URL: #7055
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Refs: #6990
MylesBorins mentioned this pull request Jul 12, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
test: remove modifcation to common.PORT
58a3852 
A possibly-buggy fixture server uses `common.PORT+1000` for its port
rather than `common.PORT`. That could result in it clashing with other
ports if tests are run in parallel. The test runner increments
`common.PORT` by 100 for each running instance for tests. Change to use
common.PORT and have the tests that use the fixture start with
common.PORT+1 for anything they need.

PR-URL: #6990
Refs: #6989
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
test: remove non-incremental common.PORT changes
6a85acc 
Remove uses of `common.PORT + 1337` where `common.PORT` suffices.

PR-URL: #7055
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Refs: #6990
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
test: remove modifcation to common.PORT
cde3014 
A possibly-buggy fixture server uses `common.PORT+1000` for its port
rather than `common.PORT`. That could result in it clashing with other
ports if tests are run in parallel. The test runner increments
`common.PORT` by 100 for each running instance for tests. Change to use
common.PORT and have the tests that use the fixture start with
common.PORT+1 for anything they need.

PR-URL: #6990
Refs: #6989
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
test: remove non-incremental common.PORT changes
5b1f546 
Remove uses of `common.PORT + 1337` where `common.PORT` suffices.

PR-URL: #7055
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Refs: #6990
Trott deleted the no-plus branch January 13, 2022 22:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL