FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: add `added:` information for vm by addaleax · Pull Request #7011 · nodejs/node · GitHub

/ node Public

doc: add added: information for vm - #7011

Closed
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:add-added-vm
ConversationCommits (1)ChecksFiles changed
Closed

doc: add added: information for vm#7011
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:add-added-vm

Conversation

addaleax commented May 27, 2016

Copy link
Copy Markdown
Member
Checklist
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)

doc, vm

Description of change

Ref: #6578

addaleax added doc Issues and PRs related to the documentations. vm Issues and PRs related to the vm subsystem. labels May 27, 2016
sam-github mentioned this pull request May 27, 2016
Closed
36 tasks
bnoordhuis reviewed May 27, 2016
View reviewed changes
Comment thread doc/api/vm.md Outdated

bnoordhuis May 27, 2016 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

vm.isContext() was added in v0.11.7. (EDIT: Commit 9c110d8.)

bnoordhuis commented May 27, 2016

Copy link
Copy Markdown
Member

LGTM with a comment.

addaleax commented May 27, 2016

Copy link
Copy Markdown
Member Author

Updated with @bnoordhuis’ correction

jasnell commented May 27, 2016

Copy link
Copy Markdown
Member

LGTM

1 similar comment

julianduque commented May 27, 2016

Copy link
Copy Markdown
Contributor

LGTM

julianduque commented May 28, 2016

Copy link
Copy Markdown
Contributor

Landed in 6c56d7b, thanks @addaleax

addaleax commented May 28, 2016

Copy link
Copy Markdown
Member Author

@julianduque Sorry for getting in the way here, but I force-pushed to master to fix metadata from #6995 … Will re-land this myself, though :)

julianduque commented May 28, 2016

Copy link
Copy Markdown
Contributor

race condition

addaleax commented May 28, 2016

Copy link
Copy Markdown
Member Author

16f98e5 it is :)

addaleax added a commit that referenced this pull request May 28, 2016
doc: add added: information for vm
16f98e5 
Ref: #6578
PR-URL: #7011
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Julian Duque <julianduquej@gmail.com>
Fishrock123 pushed a commit to Fishrock123/node that referenced this pull request May 30, 2016
doc: add added: information for vm
c0be05e 
Ref: nodejs#6578
PR-URL: nodejs#7011
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Julian Duque <julianduquej@gmail.com>
rvagg pushed a commit that referenced this pull request Jun 2, 2016
doc: add added: information for vm
216a3cd 
Ref: #6578
PR-URL: #7011
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Julian Duque <julianduquej@gmail.com>
MylesBorins mentioned this pull request Jul 11, 2016
Closed
addaleax added a commit to addaleax/node that referenced this pull request Jul 12, 2016
doc: add added: information for vm
3622c7d 
Ref: nodejs#6578
PR-URL: nodejs#7011
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Julian Duque <julianduquej@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
doc: add added: information for vm
c64288e 
Ref: #6578
PR-URL: #7011
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Julian Duque <julianduquej@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
doc: add added: information for vm
a0a3616 
Ref: #6578
PR-URL: #7011
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Julian Duque <julianduquej@gmail.com>
MylesBorins mentioned this pull request Jul 12, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
doc: add added: information for vm
2f0499b 
Ref: #6578
PR-URL: #7011
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Julian Duque <julianduquej@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
doc: add added: information for vm
7abfb6e 
Ref: #6578
PR-URL: #7011
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Julian Duque <julianduquej@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations. vm Issues and PRs related to the vm subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL