FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: add `added:` information for tls by italoacasas · Pull Request #7018 · nodejs/node · GitHub

/ node Public

doc: add added: information for tls - #7018

Closed
italoacasas wants to merge 25 commits into
nodejs:masterfrom
italoacasas:docs/add-added-tls
ConversationCommits (25)ChecksFiles changed
Closed

doc: add added: information for tls#7018
italoacasas wants to merge 25 commits into
nodejs:masterfrom
italoacasas:docs/add-added-tls

Conversation

italoacasas commented May 27, 2016 •
edited
Loading

Copy link
Copy Markdown
Checklist
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)
  • doc
Description of change

Add added: information for tls

Ref: #6578

nodejs-github-bot added the doc Issues and PRs related to the documentations. label May 27, 2016
addaleax added wip Issues and PRs that are still a work in progress. tls Issues and PRs related to the tls subsystem. labels May 27, 2016
jasnell reviewed May 27, 2016
View reviewed changes
Comment thread doc/api/tls.md
requests. Defaults to `3`.
* `tls.CLIENT_RENEG_WINDOW` {number} Specifies the time renegotiation window
in seconds. Defaults to `600` (10 minutes).

jasnell May 27, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Unnecessary whitespace change

jasnell commented May 27, 2016

Copy link
Copy Markdown
Member

LGTM with a nit

addaleax reviewed May 27, 2016
View reviewed changes
Comment thread doc/api/tls.md Outdated

## tls.getCiphers()
<!--YAML
v0.10.2

addaleax May 27, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

this should have added: before it

jasnell May 27, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

sigh.. completely overlooked that ;-) good catch.

jasnell commented May 27, 2016

Copy link
Copy Markdown
Member

(correction, LGTM with nits addressed ;-) ...)

italoacasas commented May 28, 2016

Copy link
Copy Markdown
Author

@addaleax this is done.

addaleax reviewed May 28, 2016
View reviewed changes
Comment thread doc/api/tls.md Outdated
### tlsSocket.getEphemeralKeyInfo()

<!--YAML
added: v5.0.0-rc.1

addaleax May 28, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Release candidates don’t really count, you can just set this to v5.0.0

addaleax removed the wip Issues and PRs that are still a work in progress. label May 28, 2016
addaleax reviewed Jun 10, 2016
View reviewed changes
Comment thread doc/api/tls.md
### server.listen(port[, hostname][, callback])
<!-- YAML
added: v0.11.3
-->

addaleax Jun 10, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

inherited from net.Server?

italoacasas commented Jun 10, 2016

Copy link
Copy Markdown
Author

I'm going to review this entire module again.

addaleax commented Jun 19, 2016

Copy link
Copy Markdown
Member

LGTM

addaleax commented Jun 23, 2016

Copy link
Copy Markdown
Member

Landed in c2e6078 with minor whitespace fixups, thanks!

addaleax closed this Jun 23, 2016
addaleax pushed a commit that referenced this pull request Jun 23, 2016
doc: add added: information for tls
c2e6078 
Ref: #6578
PR-URL: #7018
Reviewed-By: Anna Henningsen <anna@addaleax.net>
sam-github mentioned this pull request Jun 23, 2016
Closed
36 tasks
Fishrock123 pushed a commit that referenced this pull request Jun 27, 2016
doc: add added: information for tls
98b7cd6 
Ref: #6578
PR-URL: #7018
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Fishrock123 mentioned this pull request Jun 27, 2016
Merged
Fishrock123 pushed a commit that referenced this pull request Jul 5, 2016
doc: add added: information for tls
7a0718b 
Ref: #6578
PR-URL: #7018
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Fishrock123 mentioned this pull request Jul 5, 2016
Merged
MylesBorins mentioned this pull request Jul 11, 2016
Closed
addaleax mentioned this pull request Jul 12, 2016
Closed
addaleax pushed a commit to addaleax/node that referenced this pull request Jul 12, 2016
doc: add added: information for tls
cbd3e58 
Ref: nodejs#6578
PR-URL: nodejs#7018
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
doc: add added: information for tls
81c7c74 
Ref: #6578
PR-URL: #7018
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
doc: add added: information for tls
81c4a86 
Ref: #6578
PR-URL: #7018
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins mentioned this pull request Jul 12, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
doc: add added: information for tls
bb18032 
Ref: #6578
PR-URL: #7018
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
doc: add added: information for tls
9b8565c 
Ref: #6578
PR-URL: #7018
Reviewed-By: Anna Henningsen <anna@addaleax.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations. tls Issues and PRs related to the tls subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL