FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: add `added:` information for net by italoacasas · Pull Request #7038 · nodejs/node · GitHub

/ node Public

doc: add added: information for net - #7038

Merged
addaleax merged 40 commits into
nodejs:masterfrom
italoacasas:docs/add-added-net
Jun 3, 2016
ConversationCommits (40)ChecksFiles changed
Merged

doc: add added: information for net#7038
addaleax merged 40 commits into
nodejs:masterfrom
italoacasas:docs/add-added-net

Conversation

italoacasas commented May 28, 2016

Copy link
Copy Markdown
Checklist
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)
  • doc
Description of change

Add added: information for net

Ref: #6578

nodejs-github-bot added the doc Issues and PRs related to the documentations. label May 28, 2016
mscdex added the net Issues and PRs related to the net subsystem. label May 28, 2016
sam-github mentioned this pull request May 28, 2016
Closed
36 tasks
addaleax reviewed May 29, 2016
View reviewed changes
Comment thread doc/api/net.md Outdated

## Class: net.Server
<!-- YAML
added: v0.7.5

addaleax May 29, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Are you sure? The docs change in which it was introduced seems to be in 499c615

italoacasas May 31, 2016

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

yeap you are right. thanks

addaleax commented Jun 1, 2016

Copy link
Copy Markdown
Member

Generally looking good, with a few comments… really appreciate the hard work behind this!

italoacasas commented Jun 1, 2016 •
edited
Loading

Copy link
Copy Markdown
Author

tomorrow I'm going to check server.listen because is a little bit more harder to find, thanks for the help @addaleax

addaleax commented Jun 2, 2016

Copy link
Copy Markdown
Member

LGTM

addaleax merged commit 8bccc9e into nodejs:master Jun 3, 2016

addaleax commented Jun 3, 2016

Copy link
Copy Markdown
Member

Merged, thanks for the effort you put into this!

evanlucas pushed a commit that referenced this pull request Jun 15, 2016
doc: add added information for net
026bf17 
Ref: #6578
PR-URL: #7038
Reviewed-By: Anna Henningsen <anna@addaleax.net>
evanlucas mentioned this pull request Jun 16, 2016
Merged
MylesBorins mentioned this pull request Jul 11, 2016
Closed
addaleax pushed a commit to addaleax/node that referenced this pull request Jul 12, 2016
doc: add added information for net
1046532 
Ref: nodejs#6578
PR-URL: nodejs#7038
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
doc: add added information for net
664dc3b 
Ref: #6578
PR-URL: #7038
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
doc: add added information for net
db153ea 
Ref: #6578
PR-URL: #7038
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins mentioned this pull request Jul 12, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
doc: add added information for net
99723b2 
Ref: #6578
PR-URL: #7038
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
doc: add added information for net
78d361b 
Ref: #6578
PR-URL: #7038
Reviewed-By: Anna Henningsen <anna@addaleax.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations. net Issues and PRs related to the net subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL