FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: fix tests for non-crypto builds by addaleax · Pull Request #7056 · nodejs/node · GitHub

/ node Public

test: fix tests for non-crypto builds - #7056

Closed
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:fix-tests-for-disabled-features
ConversationCommits (1)ChecksFiles changed
Closed

test: fix tests for non-crypto builds#7056
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:fix-tests-for-disabled-features

Conversation

addaleax commented May 29, 2016 •
edited
Loading

Copy link
Copy Markdown
Member
Checklist
  • tests and code linting passes
  • the commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change

Fix running the tests when node was compiled without crypto support. Some of these were introduced in 52bae22, where common was used before it was required.

Regular CI: https://ci.nodejs.org/job/node-test-commit/3575/

/cc @nodejs/testing

addaleax added the test Issues and PRs related to the tests. label May 29, 2016

Trott commented May 30, 2016

Copy link
Copy Markdown
Member

LGTM if CI doesn't find any surprises

mscdex added the crypto Issues and PRs related to the crypto subsystem. label May 30, 2016

bnoordhuis commented May 30, 2016

Copy link
Copy Markdown
Member

Nice, LGTM.

santigimeno commented May 30, 2016

Copy link
Copy Markdown
Member

LGTM

mscdex reviewed May 30, 2016
View reviewed changes
Comment thread test/parallel/test-async-wrap-check-providers.js Outdated

mscdex May 30, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Perhaps the crypto AsyncWrap test can merely be isolated instead of aborting the entire test?

addaleax Jun 5, 2016

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Hm, this test is basically laid out to use all providers, so I guess that would really require its own test file… I’m not sure that’s worth the trouble.

jasnell commented Jun 6, 2016

Copy link
Copy Markdown
Member

Minor aside: I've been wondering about the possibility of refactoring common.js into a pre-loaded module that makes it (and assert) globals for all tests... allowing us to move away from having to require() it explicitly in every file.

jasnell commented Jun 6, 2016

Copy link
Copy Markdown
Member

LGTM

thefourtheye commented Jun 6, 2016

Copy link
Copy Markdown
Contributor

@jasnell regarding preloading common, #2836 (comment)

test: fix tests for non-crypto builds
df2777b 
Fix running the tests when node was compiled without crypto
support. Some of these are cleanup after 52bae22, where
common was used before it was required.
addaleax force-pushed the fix-tests-for-disabled-features branch from 37f4f9b to df2777b Compare June 7, 2016 05:30

addaleax commented Jun 7, 2016 •
edited
Loading

Copy link
Copy Markdown
Member Author

Addressed @jasnell’s nit, one more CI: https://ci.nodejs.org/job/node-test-commit/3675/ again because that one had some infrastructure problems: https://ci.nodejs.org/job/node-test-commit/3691/

addaleax commented Jun 8, 2016 •
edited
Loading

Copy link
Copy Markdown
Member Author

Landed in 15cd45c

addaleax closed this Jun 8, 2016
addaleax deleted the fix-tests-for-disabled-features branch June 8, 2016 09:43
addaleax added a commit that referenced this pull request Jun 8, 2016
test: fix tests for non-crypto builds
15cd45c 
Fix running the tests when node was compiled without crypto
support. Some of these are cleanup after 52bae22, where
common was used before it was required.

PR-URL: #7056
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

evanlucas commented Jun 16, 2016

Copy link
Copy Markdown
Contributor

This is not landing cleanly on v6.x, so going to hold off for now

MylesBorins mentioned this pull request Jul 11, 2016
Closed

MylesBorins commented Jul 11, 2016

Copy link
Copy Markdown
Contributor

@addaleax assuming dont land on v4.x?

addaleax commented Jul 11, 2016

Copy link
Copy Markdown
Member Author

Seems okay not to backport, yes.

gibfahn mentioned this pull request Jun 15, 2017
Closed
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

crypto Issues and PRs related to the crypto subsystem. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

Back | FazBrowse Home | New Git URL