FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: add linebreak to --inspect message by nicolasromer · Pull Request #7070 · nodejs/node · GitHub

/ node Public

src: add linebreak to --inspect message - #7070

Closed
nicolasromer wants to merge 2 commits into
nodejs:masterfrom
nicolasromer:inspector-fix-linebreak
ConversationCommits (2)ChecksFiles changed
Closed

src: add linebreak to --inspect message#7070
nicolasromer wants to merge 2 commits into
nodejs:masterfrom
nicolasromer:inspector-fix-linebreak

Conversation

nicolasromer commented May 30, 2016

Copy link
Copy Markdown
Contributor
Checklist
  • the commit message follows commit guidelines
Affected core subsystem(s)

src

Description of change

Added a newline in --inspect message after "Debugger listening on port %d." to prevent an ugly line break in 80 column(default) terminal windows

nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label May 30, 2016
addaleax reviewed May 30, 2016
View reviewed changes
Comment thread src/inspector_agent.cc Outdated

addaleax May 30, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

If there’s a line break here anyway, the preceding space might as well be removed, no?

addaleax commented May 30, 2016 •
edited
Loading

Copy link
Copy Markdown
Member

LGTM, thanks! For reference, this fixes bug #7067; you can include a Fixes: https://github.com/nodejs/node/issues/7067 line in your commit message, but that can also be done when landing the commit. :-)

src: add linebreak to inspector message
79e073e 
to prevent ugly line break in 80 column(default) terminal windows

Fixes: nodejs#7067

nicolasromer commented May 30, 2016

Copy link
Copy Markdown
Contributor Author

Aha, I was wondering how to link the issue to the pull request – I'll add that to the log. Might be useful to mention in the contributing doc.

nicolasromer force-pushed the inspector-fix-linebreak branch from da38af3 to 79e073e Compare May 30, 2016 21:24
MylesBorins mentioned this pull request May 31, 2016
Closed

claudiorodriguez commented May 31, 2016 •
edited
Loading

Copy link
Copy Markdown
Contributor

LGTM, second commit will need to be fixed-up but I can do that while landing (also probably change the word "ugly" just to be extra safe with the CoC).

CI: https://ci.nodejs.org/job/node-test-pull-request/2876/

claudiorodriguez commented Jun 1, 2016

Copy link
Copy Markdown
Contributor

CI failure unrelated as far as I can see

cjihrig commented Jun 1, 2016

Copy link
Copy Markdown
Contributor

LGTM

claudiorodriguez pushed a commit that referenced this pull request Jun 2, 2016
src: add linebreak to inspector message
3549a5e 
Add linebreak to inspector ready message to wrap properly in
80 column (default) terminal windows.

Fixes: #7067
PR-URL: #7070
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

claudiorodriguez commented Jun 2, 2016

Copy link
Copy Markdown
Contributor

Landed in 3549a5e

MylesBorins added this to the 7.0.0 milestone Jun 14, 2016
MylesBorins added inspector Issues and PRs related to the V8 inspector protocol dont-land-on-v6.x labels Jun 14, 2016
Fishrock123 pushed a commit that referenced this pull request Jul 5, 2016
src: add linebreak to inspector message
643b33b 
Add linebreak to inspector ready message to wrap properly in
80 column (default) terminal windows.

Fixes: #7067
PR-URL: #7070
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Fishrock123 mentioned this pull request Jul 5, 2016
Merged
MylesBorins mentioned this pull request Jul 11, 2016
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. inspector Issues and PRs related to the V8 inspector protocol

Projects

None yet

Milestone

7.0.0

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL