FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: enable test-debug-brk-no-arg by Trott · Pull Request #7143 · nodejs/node · GitHub

/ node Public

test: enable test-debug-brk-no-arg - #7143

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:undis
ConversationCommits (1)ChecksFiles changed
Closed

test: enable test-debug-brk-no-arg#7143
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:undis

Conversation

Trott commented Jun 3, 2016

Copy link
Copy Markdown
Member
Checklist
  • tests and code linting passes
  • the commit message follows commit guidelines
Affected core subsystem(s)

test debugger

Description of change

Fix issues with disabled test-debug-brk-no-arg and re-enable the test.

test: enable test-debug-brk-no-arg
287e57c 
Fix issues with disabled test-debug-brk-no-arg and re-enable the test.
Trott added debugger test Issues and PRs related to the tests. labels Jun 3, 2016
Fishrock123 reviewed Jun 3, 2016
View reviewed changes
Comment thread test/parallel/test-debug-brk-no-arg.js
child.stdin.end('.exit');
}));

child.on('exit', common.mustCall(function(c) {

Fishrock123 Jun 3, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

should this be 'close'?

Trott Jun 4, 2016

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

In this particular case, I don't think it matters either way. But I'm happy to change it to close if that is more idiomatic or avoids problems that I'm currently unaware of in the existing code.

Trott commented Jun 4, 2016

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/2921/

Trott commented Jun 4, 2016

Copy link
Copy Markdown
Member Author

Only failure was a build failure on a Raspberry Pi. Trying again: https://ci.nodejs.org/job/node-test-pull-request/2923/

Trott commented Jun 5, 2016

Copy link
Copy Markdown
Member Author

R=@indutny?

indutny commented Jun 5, 2016

Copy link
Copy Markdown
Member

LGTM if it works

indutny commented Jun 5, 2016

Copy link
Copy Markdown
Member

@Trott I'd suggest running stress tests for it, just to be sure that it won't be flaky in the future.

Trott commented Jun 6, 2016

Copy link
Copy Markdown
Member Author

@Trott I'd suggest running stress tests for it, just to be sure that it won't be flaky in the future.

Not sure the last time anyone tried to run a stress test across all targets, but here we go! https://ci.nodejs.org/job/node-stress-single-test/754/

Trott commented Jun 6, 2016

Copy link
Copy Markdown
Member Author

Stress test results: One build failure, one Jenkins misconfiguration (since fixed, but it resulted in the job getting canceled), and a whole bunch of green across Windows, Raspberry Pi, Linux, OS X, etc.

Trott added a commit to Trott/io.js that referenced this pull request Jun 7, 2016
test: enable test-debug-brk-no-arg
101bda1 
Fix issues with disabled test-debug-brk-no-arg and re-enable the test.

PR-URL: nodejs#7143
Reviewed-By: Fedor Indutny <fedor@indutny.com>

Trott commented Jun 7, 2016

Copy link
Copy Markdown
Member Author

Landed in 101bda1

Trott closed this Jun 7, 2016
evanlucas pushed a commit that referenced this pull request Jun 15, 2016
test: enable test-debug-brk-no-arg
e873063 
Fix issues with disabled test-debug-brk-no-arg and re-enable the test.

PR-URL: #7143
Reviewed-By: Fedor Indutny <fedor@indutny.com>
evanlucas mentioned this pull request Jun 16, 2016
Merged
MylesBorins mentioned this pull request Jul 11, 2016
Closed
MylesBorins pushed a commit that referenced this pull request Jul 11, 2016
test: enable test-debug-brk-no-arg
884c4ee 
Fix issues with disabled test-debug-brk-no-arg and re-enable the test.

PR-URL: #7143
Reviewed-By: Fedor Indutny <fedor@indutny.com>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
test: enable test-debug-brk-no-arg
a790d52 
Fix issues with disabled test-debug-brk-no-arg and re-enable the test.

PR-URL: #7143
Reviewed-By: Fedor Indutny <fedor@indutny.com>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
test: enable test-debug-brk-no-arg
b89286a 
Fix issues with disabled test-debug-brk-no-arg and re-enable the test.

PR-URL: #7143
Reviewed-By: Fedor Indutny <fedor@indutny.com>
MylesBorins mentioned this pull request Jul 12, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
test: enable test-debug-brk-no-arg
c5c7603 
Fix issues with disabled test-debug-brk-no-arg and re-enable the test.

PR-URL: #7143
Reviewed-By: Fedor Indutny <fedor@indutny.com>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
test: enable test-debug-brk-no-arg
96ed883 
Fix issues with disabled test-debug-brk-no-arg and re-enable the test.

PR-URL: #7143
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Trott deleted the undis branch January 13, 2022 22:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL