FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

inspector: reduce implementation in header by ofrobots · Pull Request #7228 · nodejs/node · GitHub

/ node Public

inspector: reduce implementation in header - #7228

Closed
ofrobots wants to merge 1 commit into
nodejs:masterfrom
ofrobots:inspector-pimpl
ConversationCommits (1)ChecksFiles changed
Closed

inspector: reduce implementation in header#7228
ofrobots wants to merge 1 commit into
nodejs:masterfrom
ofrobots:inspector-pimpl

Conversation

ofrobots commented Jun 8, 2016

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX) or vcbuild test nosign (Windows) passes
  • the commit message follows commit guidelines
Affected core subsystem(s)

inspector

Description of change

This is needed to reduce the coupling between node files that use
node::Environment and inspector class.

Fixes: #7080

ofrobots added the inspector Issues and PRs related to the V8 inspector protocol label Jun 8, 2016
nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Jun 8, 2016

bnoordhuis commented Jun 9, 2016

Copy link
Copy Markdown
Member

LGTM

inspector: reduce implementation in header
f2ce8da 
This is needed to reduce the coupling between node files that use
node::Environment and inspector class.

Fixes: nodejs#7080

ofrobots commented Jun 9, 2016

Copy link
Copy Markdown
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/2966/

ofrobots pushed a commit that referenced this pull request Jun 10, 2016
inspector: reduce implementation in header
624734e 
This is needed to reduce the coupling between node files that use
node::Environment and inspector class.

Fixes: #7080
PR-URL: #7228
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>

ofrobots commented Jun 10, 2016

Copy link
Copy Markdown
Contributor Author

Thanks landed as 624734e.

ofrobots closed this Jun 10, 2016
MylesBorins added this to the 7.0.0 milestone Jun 14, 2016
MylesBorins mentioned this pull request Jun 14, 2016
Closed
Fishrock123 pushed a commit that referenced this pull request Jul 5, 2016
inspector: reduce implementation in header
7da8a41 
This is needed to reduce the coupling between node files that use
node::Environment and inspector class.

Fixes: #7080
PR-URL: #7228
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>

 Conflicts:
	src/node.cc
Fishrock123 mentioned this pull request Jul 5, 2016
Merged
MylesBorins mentioned this pull request Jul 11, 2016
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. inspector Issues and PRs related to the V8 inspector protocol

Projects

None yet

Milestone

7.0.0

Development

Successfully merging this pull request may close these issues.

New Failures in AIX nightly run (possibly v8_inspector change)

5 participants

Back | FazBrowse Home | New Git URL