FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

inspector: process.exit should wait for inspector by eugeneo · Pull Request #7252 · nodejs/node · GitHub

/ node Public

inspector: process.exit should wait for inspector - #7252

Closed
eugeneo wants to merge 1 commit into
nodejs:masterfrom
eugeneo:on_exit
ConversationCommits (1)ChecksFiles changed
Closed

inspector: process.exit should wait for inspector#7252
eugeneo wants to merge 1 commit into
nodejs:masterfrom
eugeneo:on_exit

Conversation

eugeneo commented Jun 9, 2016

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX) or vcbuild test nosign (Windows) passes
  • the commit message follows commit guidelines
Affected core subsystem(s)

inspector

Description of change

Waits for the inspector frontend to detach when process.exit is called. This enables the user to analyse the profiling information.

Fixes: #7088

nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Jun 9, 2016

eugeneo commented Jun 9, 2016

Copy link
Copy Markdown
Contributor Author

@ofrobots

pavelfeldman commented Jun 9, 2016

Copy link
Copy Markdown
Contributor

lgtm

ofrobots commented Jun 9, 2016

Copy link
Copy Markdown
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/2967/

bnoordhuis commented Jun 10, 2016

Copy link
Copy Markdown
Member

LGTM

bnoordhuis commented Jun 10, 2016

Copy link
Copy Markdown
Member

For bonus points: factor out that magic number 32 into a constant and update PlatformInit() and WaitForInspectorDisconnect().

eugeneo commented Jun 10, 2016

Copy link
Copy Markdown
Contributor Author

@bnoordhuis I introduced a constant and rebased the CL

bnoordhuis reviewed Jun 10, 2016
View reviewed changes
Comment thread src/node.cc Outdated

bnoordhuis Jun 10, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Can you name it e.g. kNumSignals or kMaxSignal? ALL_CAPS should be reserved for macros. LGTM apart from that.

eugeneo commented Jun 10, 2016

Copy link
Copy Markdown
Contributor Author

@bnoordhuis I renamed to kMaxSignal. Thanks!

ofrobots commented Jun 10, 2016

Copy link
Copy Markdown
Contributor

New CI: https://ci.nodejs.org/job/node-test-pull-request/2982/

bnoordhuis commented Jun 11, 2016

Copy link
Copy Markdown
Member

LGTM. ppcbe-ubuntu1404 seems to be stuck but everything else is green.

ofrobots commented Jun 13, 2016

Copy link
Copy Markdown
Contributor

Thanks, landed as 6626919.

ofrobots closed this Jun 13, 2016
ofrobots pushed a commit that referenced this pull request Jun 13, 2016
inspector: process.exit should wait for inspector
6626919 
Fixes: #7088
PR-URL: #7252
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>

evanlucas commented Jun 16, 2016

Copy link
Copy Markdown
Contributor

I am excluding this one from the next v6.x release since it is just a semver patch release. Once the inspector lands in v6.x, we can remove the dont-land-on-v6.x label. Thanks!

Fishrock123 pushed a commit that referenced this pull request Jul 5, 2016
inspector: process.exit should wait for inspector
88b2aa3 
Fixes: #7088
PR-URL: #7252
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>

 Conflicts:
	src/node.cc
Fishrock123 mentioned this pull request Jul 5, 2016
Merged
MylesBorins mentioned this pull request Jul 11, 2016
Closed
alexdima mentioned this pull request Aug 25, 2017
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

--inspect connection dies before profiler captures trace

8 participants

Back | FazBrowse Home | New Git URL