benchmark: util._extend vs object.assign - #7255
Closed
suryagh wants to merge 4 commits into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
To copy the values of all enumerable own properties from- a source object to a target object, node still use- `util._extend`, though newer standard `Object.assign` is available. This is because `util._extend` is found to be faster than `Object.assign`. This benchmark test is to keep track of how performance compare.
2 tasks
Comment thread
benchmark/misc/util-extend-vs-object-assign.js
Outdated
|
|
||
| const bench = common.createBenchmark(main, { | ||
| type: ['util._extend', 'Object.assign', | ||
| 'util._extend', 'Object.assign'], |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Why are there duplicates?
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
Removed.
Sorry, something went wrong.
Comment thread
benchmark/misc/util-extend-vs-object-assign.js
| if (conf.type === 'extend') { | ||
| fn = util._extend; | ||
| v8command = '%OptimizeFunctionOnNextCall(util._extend)'; | ||
| } else if (conf.type === 'assign') { |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
FYI: https://github.com/nodejs/node/blob/master/benchmark/common.js#L255
the benchmark/common.js now has a method for handling the details of v8 optimization for you. e.g.
function myMethod(a,b) {
/** ... **/
}
common.v8ForceOptimization(myMethod, 'a', 'b');
myMethod('a', 'b');
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Couple of minor nits but LGTM if @mscdex is happy with it. |
Sorry, something went wrong.
Comment thread
benchmark/misc/util-extend-vs-object-assign.js
Outdated
| v8command = '%OptimizeFunctionOnNextCall(util._extend)'; | ||
| } else if (conf.type === 'assign') { | ||
| fn = Object.assign; | ||
| //Object.assign is built-in, cannot be optimized |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Space needed after //.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
One minor style nit, but otherwise LGTM |
Sorry, something went wrong.
fixed spacing nit.
Copy link
Copy Markdown
Contributor
Author
|
Fixed the minor style. |
Sorry, something went wrong.
jasnell
pushed a commit
that referenced
this pull request
Jun 27, 2016
To copy the values of all enumerable own properties from- a source object to a target object, node still use- `util._extend`, though newer standard `Object.assign` is available. This is because `util._extend` is found to be faster than `Object.assign`. This benchmark test is to keep track of how performance compare. PR-URL: #7255 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
Fishrock123
pushed a commit
that referenced
this pull request
Jul 5, 2016
To copy the values of all enumerable own properties from- a source object to a target object, node still use- `util._extend`, though newer standard `Object.assign` is available. This is because `util._extend` is found to be faster than `Object.assign`. This benchmark test is to keep track of how performance compare. PR-URL: #7255 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
Merged
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
benchmark
Description of change
To copy the values of all enumerable properties from-
a source object to a target object, node still use-
util._extend, though newer standard Object.assign
is available. This is because util._extend is found to
be faster than Object.assign. This benchmark test is
to keep track of how performance compare.