FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: fix --without-inspector build by addaleax · Pull Request #7258 · nodejs/node · GitHub

/ node Public

src: fix --without-inspector build - #7258

Closed
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:fix-without-inspector-build
ConversationCommits (1)ChecksFiles changed
Closed

src: fix --without-inspector build#7258
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:fix-without-inspector-build

Conversation

addaleax commented Jun 10, 2016

Copy link
Copy Markdown
Member
Checklist
  • make -j4 test (UNIX) or vcbuild test nosign (Windows) passes
  • the commit message follows commit guidelines
Affected core subsystem(s)

src (v8_inspector?)

Description of change

use_inspector is not available if HAVE_INSPECTOR is false. Before this commit, one usage of it would show up as an undeclared identifier (introduced in a766ebf).

src: fix --without-inspector build
a5ec950 
`use_inspector` is not available if `HAVE_INSPECTOR` is false.
Before this commit, one usage of it would show up as an undeclared
identifier (introduced in a766ebf).
addaleax added c++ Issues and PRs that require attention from people who are familiar with C++. inspector Issues and PRs related to the V8 inspector protocol labels Jun 10, 2016

addaleax commented Jun 10, 2016

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-commit/3708/

bnoordhuis mentioned this pull request Jun 10, 2016
Closed

bnoordhuis commented Jun 10, 2016

Copy link
Copy Markdown
Member

LGTM

1 similar comment

cjihrig commented Jun 13, 2016

Copy link
Copy Markdown
Contributor

LGTM

addaleax commented Jun 13, 2016

Copy link
Copy Markdown
Member Author

Landed in 0c73c9f

addaleax closed this Jun 13, 2016
addaleax added a commit that referenced this pull request Jun 13, 2016
src: fix --without-inspector build
0c73c9f 
`use_inspector` is not available if `HAVE_INSPECTOR` is false.
Before this commit, one usage of it would show up as an undeclared
identifier (introduced in a766ebf).

PR-URL: #7258
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax deleted the fix-without-inspector-build branch June 13, 2016 15:04
MylesBorins added this to the 7.0.0 milestone Jun 14, 2016
MylesBorins mentioned this pull request Jun 14, 2016
Closed
Fishrock123 pushed a commit that referenced this pull request Jul 5, 2016
src: fix --without-inspector build
38d36e3 
`use_inspector` is not available if `HAVE_INSPECTOR` is false.
Before this commit, one usage of it would show up as an undeclared
identifier (introduced in a766ebf).

PR-URL: #7258
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Fishrock123 mentioned this pull request Jul 5, 2016
Merged
MylesBorins mentioned this pull request Jul 11, 2016
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. inspector Issues and PRs related to the V8 inspector protocol

Projects

None yet

Milestone

7.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL