FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: move and update comment about 'node.js' compilation. by danbev · Pull Request #7277 · nodejs/node · GitHub

/ node Public

src: move and update comment about 'node.js' compilation. - #7277

Closed
danbev wants to merge 4 commits into
nodejs:masterfrom
danbev:move-and-update-node.js-source-compilation
ConversationCommits (4)ChecksFiles changed
Closed

src: move and update comment about 'node.js' compilation.#7277
danbev wants to merge 4 commits into
nodejs:masterfrom
danbev:move-and-update-node.js-source-compilation

Conversation

danbev commented Jun 12, 2016

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX) or vcbuild test nosign (Windows) passes
  • the commit message follows commit guidelines
Affected core subsystem(s)

src

Description of change

Currently the comment regarding execution of src/node.js seems to refer
to the file before the refactorings done in ec6af31. Also, it looks like
the comment itself might have "drifted" a little in the file.

Updated the comment to refer to the lib/internal/bootstrap_node.js file,
moved it closer to the compilation step, and updated the name that is
generated in node_natives.h.

src: move and update comment about 'node.js' compilation.
f19e968 
Currently the comment regarding execution of src/node.js seems to refer
to the file before the refactorings done in ec6af31. Also, it looks like
the comment itself might have "drifted" a little in the file.

Updated the comment to refer to the lib/internal/bootstrap_node.js file,
moved it closer to the compilation step, and updated the name that is
generated in node_natives.h.
nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Jun 12, 2016
mscdex reviewed Jun 12, 2016
View reviewed changes
Comment thread src/node.cc Outdated
// Compile, execute the lib/internal/bootstrap_node.js file. (Which was
// included as static C string in node_natives.h.
// 'internal_bootstrap_node_native is the string containing that source code.)
Local<String> script_name = FIXED_ONE_BYTE_STRING(env->isolate(), "node.js");

mscdex Jun 12, 2016 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Perhaps this script name should be updated too since it has been named bootstrap_node.js for some time now?

cjihrig Jun 13, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

+1 to updating this.

danbev Jun 13, 2016

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I'll take a stab at changing this to bootstrap_node.js.

cjihrig reviewed Jun 14, 2016
View reviewed changes
Comment thread src/node.cc
try_catch.SetVerbose(false);

// Execute the lib/internal/bootstrap_node.js file which was included as a
// static in node_natives.h by node_js2c. 'internal_bootstrap_node_native'

cjihrig Jun 14, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

static -> static C string

cjihrig commented Jun 14, 2016

Copy link
Copy Markdown
Contributor

Don't forget about #7277 (comment)

cjihrig reviewed Jun 14, 2016
View reviewed changes
Comment thread src/node.cc Outdated
// is the string containing that source code.
Local<String> script_name = FIXED_ONE_BYTE_STRING(env->isolate(), "node.js");
Local<String> script_name = FIXED_ONE_BYTE_STRING(env->isolate(),
"bootstrap_node.js");

cjihrig Jun 14, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Can you line up the opening " with the e in env on the previous line.

danbev Jun 14, 2016

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Absolutely, move it now.

mscdex commented Jun 14, 2016

Copy link
Copy Markdown
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/2996/

cjihrig reviewed Jun 15, 2016
View reviewed changes
Comment thread src/node.cc

Local<String> script_name = FIXED_ONE_BYTE_STRING(env->isolate(), "node.js");
// Execute the lib/internal/bootstrap_node.js file which was included as a
// static in node_natives.h by node_js2c. 'internal_bootstrap_node_native'

cjihrig Jun 15, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

static -> static C string

cjihrig commented Jun 15, 2016

Copy link
Copy Markdown
Contributor

The CI had a Jenkins failure, and some Alpine failures which have since been corrected. LGTM

mscdex commented Jun 15, 2016

Copy link
Copy Markdown
Contributor

LGTM

danbev commented Jun 16, 2016

Copy link
Copy Markdown
Contributor Author

@cjihrig @mscdex Thanks for the reviews!

cjihrig pushed a commit that referenced this pull request Jun 17, 2016
src: rename "node" script to "bootstrap_node"
81b6882 
This commit updates the node.js script name to reflect its
actual name, which is now bootstrap_node.js. This commit also
fixes the requisite message tests, and relocates a comment
which seems to have drifted.

PR-URL: #7277
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>

cjihrig commented Jun 17, 2016

Copy link
Copy Markdown
Contributor

Landed in 81b6882. Thanks!

cjihrig closed this Jun 17, 2016
evanlucas pushed a commit that referenced this pull request Jun 27, 2016
src: rename "node" script to "bootstrap_node"
6dc0dae 
This commit updates the node.js script name to reflect its
actual name, which is now bootstrap_node.js. This commit also
fixes the requisite message tests, and relocates a comment
which seems to have drifted.

PR-URL: #7277
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Fishrock123 mentioned this pull request Jun 27, 2016
Merged
Fishrock123 mentioned this pull request Jul 5, 2016
Merged
MylesBorins mentioned this pull request Jul 11, 2016
Closed

MylesBorins commented Jul 11, 2016

Copy link
Copy Markdown
Contributor

@cjihrig lts?

cjihrig commented Jul 12, 2016

Copy link
Copy Markdown
Contributor

No, I believe this is accurate in v4.

danbev deleted the move-and-update-node.js-source-compilation branch September 7, 2016 08:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL