doc: Correct added: information for fs.access and fs.accessSync - #7299
Closed
richardlau wants to merge 1 commit into
Closed
doc: Correct added: information for fs.access and fs.accessSync#7299richardlau wants to merge 1 commit into
richardlau wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
fs.access and fs.accessSync were added to Node v0.11.15 via 2944934
Copy link
Copy Markdown
Member
|
Thanks! The commit subject line should be lower-case and is a bit too long, but other than that LGTM. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
@addaleax thanks. I've changed the commit subject line to lower-case and chopped the end off to fit into 50 characters. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Yup, seems good. Thanks! :) |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
addaleax
pushed a commit
that referenced
this pull request
Jun 18, 2016
evanlucas
pushed a commit
that referenced
this pull request
Jun 27, 2016
Merged
Merged
addaleax
pushed a commit
to addaleax/node
that referenced
this pull request
Jul 12, 2016
fs.access and fs.accessSync were added to Node v0.11.15 via 2944934 PR-URL: nodejs#7299 Reviewed-By: Anna Henningsen <anna@addaleax.net> Ref: nodejs#6717 Ref: nodejs#6578
MylesBorins
pushed a commit
that referenced
this pull request
Jul 12, 2016
MylesBorins
pushed a commit
that referenced
this pull request
Jul 12, 2016
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Jul 14, 2016
MylesBorins
pushed a commit
that referenced
this pull request
Jul 14, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc
Description of change
From nodejs/node-gyp#955 (comment) it looks like the Added in: values for fs.access and fs.accessSync are incorrect. From investigations it looks like fs.access and fs.accessSync were added to Node v0.11.15 via 2944934