FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

inspector: Fix Coverty scan errors by eugeneo · Pull Request #7324 · nodejs/node · GitHub

/ node Public

inspector: Fix Coverty scan errors - #7324

Closed
eugeneo wants to merge 1 commit into
nodejs:masterfrom
eugeneo:coverty
ConversationCommits (1)ChecksFiles changed
Closed

inspector: Fix Coverty scan errors#7324
eugeneo wants to merge 1 commit into
nodejs:masterfrom
eugeneo:coverty

Conversation

eugeneo commented Jun 16, 2016

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX) or vcbuild test nosign (Windows) passes
  • the commit message follows commit guidelines
Affected core subsystem(s)

This touches inspector

Description of change

Fix a bug detected by Coverty.

CC: @ofrobots

nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Jun 16, 2016

cjihrig commented Jun 16, 2016

Copy link
Copy Markdown
Contributor

LGTM. CI: https://ci.nodejs.org/job/node-test-pull-request/3010/

mscdex added the inspector Issues and PRs related to the V8 inspector protocol label Jun 16, 2016

ofrobots commented Jun 16, 2016

Copy link
Copy Markdown
Contributor

LGTM. The CI is green.

bnoordhuis commented Jun 16, 2016

Copy link
Copy Markdown
Member

LGTM

The ASSERT_EQ a few lines up should probably be a CHECK_EQ. The buffer is filled with whatever is on the stack if uv_get_process_title() fails. It can't really happen under normal circumstances but better safe than sorry.

eugeneo commented Jun 16, 2016

Copy link
Copy Markdown
Contributor Author

@bnoordhuis I'm now setting target title to a default value if the call fails.

bnoordhuis reviewed Jun 17, 2016
View reviewed changes
Comment thread src/inspector_agent.cc Outdated

bnoordhuis Jun 17, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Can you use snprintf()? Most static analysis tools will complain about strcpy() (even if it's harmless here.)

eugeneo Jun 17, 2016

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Done. Thanks!

bnoordhuis commented Jun 17, 2016

Copy link
Copy Markdown
Member

LGTM with a comment.

ofrobots commented Jun 17, 2016

Copy link
Copy Markdown
Contributor

New CI https://ci.nodejs.org/job/node-test-pull-request/3015/ is green.

ofrobots pushed a commit that referenced this pull request Jun 17, 2016
inspector: fix coverity scan errors
dfcf02b 
PR-URL: #7324
Reviewed-By: cjihrig - Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: ofrobots - Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>

ofrobots commented Jun 17, 2016

Copy link
Copy Markdown
Contributor

Landed as dfcf02b.

ofrobots closed this Jun 17, 2016
Fishrock123 pushed a commit that referenced this pull request Jul 5, 2016
inspector: fix coverity scan errors
09ecd1f 
PR-URL: #7324
Reviewed-By: cjihrig - Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: ofrobots - Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
Fishrock123 mentioned this pull request Jul 5, 2016
Merged
MylesBorins mentioned this pull request Jul 11, 2016
Closed
eugeneo deleted the coverty branch August 2, 2016 23:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. inspector Issues and PRs related to the V8 inspector protocol

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL