FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: fix link in the stream doc by italoacasas · Pull Request #7347 · nodejs/node · GitHub

/ node Public

doc: fix link in the stream doc - #7347

Closed
italoacasas wants to merge 3 commits into
nodejs:masterfrom
italoacasas:bugfix/stream-docs
ConversationCommits (3)ChecksFiles changed
Closed

doc: fix link in the stream doc#7347
italoacasas wants to merge 3 commits into
nodejs:masterfrom
italoacasas:bugfix/stream-docs

Conversation

italoacasas commented Jun 21, 2016

Copy link
Copy Markdown
Checklist
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

Fixing typo in the documentation.

nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jun 21, 2016
italoacasas changed the title Fixing link in streams docs doc: fix link in the stream doc Jun 21, 2016
mscdex added the stream Issues and PRs related to the stream subsystem. label Jun 21, 2016

thefourtheye commented Jun 21, 2016

Copy link
Copy Markdown
Contributor

Can you fix the spelling as well? I think it is supposed to be "API for Stream Implementers".

cc @nodejs/documentation

addaleax commented Jun 21, 2016

Copy link
Copy Markdown
Member

@thefourtheye is right, it should read “Implementers”.

If you want to take a look at the others from #6947 (comment), you can to that too (I’d recommend rebasing against master first now that #7336 has landed).

italoacasas commented Jun 21, 2016

Copy link
Copy Markdown
Author

Ok i'll check the others and fix the typo.

italoacasas commented Jun 22, 2016 •
edited
Loading

Copy link
Copy Markdown
Author

This is done.

addaleax commented Jun 22, 2016

Copy link
Copy Markdown
Member

LGTM

1 similar comment

thefourtheye commented Jun 23, 2016

Copy link
Copy Markdown
Contributor

LGTM

addaleax commented Jun 23, 2016

Copy link
Copy Markdown
Member

Landed in 79f961a

addaleax closed this Jun 23, 2016
addaleax pushed a commit that referenced this pull request Jun 23, 2016
doc: fix link in the stream doc
79f961a 
fixing typo
fixing broken links

PR-URL: #7347
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Fishrock123 pushed a commit that referenced this pull request Jun 27, 2016
doc: fix link in the stream doc
6d9549c 
fixing typo
fixing broken links

PR-URL: #7347
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Fishrock123 mentioned this pull request Jun 27, 2016
Merged
Fishrock123 pushed a commit that referenced this pull request Jul 5, 2016
doc: fix link in the stream doc
eed6597 
fixing typo
fixing broken links

PR-URL: #7347
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Fishrock123 mentioned this pull request Jul 5, 2016
Merged
MylesBorins mentioned this pull request Jul 11, 2016
Closed
aliscco mentioned this pull request Jun 21, 2023
Open
This was referenced Jul 1, 2023
Open
Open
This was referenced Jul 8, 2023
Open
Open
leonardoadame mentioned this pull request Sep 30, 2023
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL