tools: explicit path for V8 test tap output - #7460
Conversation
Sorry, something went wrong.
|
modified ci job: https://ci.nodejs.org/job/thealphanerd-test-commit-v8-linux/1/ edit: modified CI is green /cc @mhdawson @nodejs/v8 |
Sorry, something went wrong.
|
/cc @nodejs/build not 100% this is the way we want to solve it... PTAL |
Sorry, something went wrong.
|
We could make it more flexible so you can specify the path, but I think this will be good for people running the test so I'm good with what you have LGTM. |
Sorry, something went wrong.
|
Lgtm |
Sorry, something went wrong.
|
LGTM |
Sorry, something went wrong.
Currently we do not specific an absolute path for the tap output of the V8 test suite. This is proving to be unreliable across release lines. By prepending `$(PWD)` to each path we can guarantee it will always be in the root folder. PR-URL: nodejs#7460 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
|
@mhdawson I've gone ahead and updated the CI job to no longer cp the file from v8 -> root as the new default is to place the xml in the root directory. This may need to be updated in other CI jobs outside of node. |
Sorry, something went wrong.
Currently we do not specific an absolute path for the tap output of the V8 test suite. This is proving to be unreliable across release lines. By prepending `$(PWD)` to each path we can guarantee it will always be in the root folder. PR-URL: nodejs#7460 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Currently we do not specific an absolute path for the tap output of the V8 test suite. This is proving to be unreliable across release lines. By prepending `$(PWD)` to each path we can guarantee it will always be in the root folder. PR-URL: #7460 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Currently we do not specific an absolute path for the tap output of the V8 test suite. This is proving to be unreliable across release lines. By prepending `$(PWD)` to each path we can guarantee it will always be in the root folder. PR-URL: #7460 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Checklist
Affected core subsystem(s)
tools
Description of change
Currently we do not specific an absolute path for the tap output of the
V8 test suite. This is proving to be unreliable across release lines.
By prepending $(PWD) to each path we can guarantee it will always be
in the root folder.
This change will require an update to the jenkins job