build: reduces unused js2c.py code - #7465
Conversation
Sorry, something went wrong.
likely those parts originate from the single commit 63a9cd3 and have never been used. This cleans up some of the implementation to have less confusions for devs visiting this file.
|
cc @nodejs/build @bnoordhuis @indutny |
Sorry, something went wrong.
|
CI is green. |
Sorry, something went wrong.
|
LGTM |
Sorry, something went wrong.
|
LGTM but s/reduces/reduce/ (or 'remove' or 'delete') and s/likely/Likely/ in the commit log. |
Sorry, something went wrong.
|
LGTM if it works (with @bnoordhuis's nits). Also, it looks like the commit message may have long line but I may be wrong. |
Sorry, something went wrong.
| output.write(HEADER_TEMPLATE % { | ||
| 'builtin_count': len(ids) + len(delay_ids), | ||
| 'delay_count': len(delay_ids), | ||
| 'source_lines': "\n".join(source_lines_empty), |
There was a problem hiding this comment.
Remove the declaration and accumulation of source_lines_empty as well. It is not used anywhere else.
Sorry, something went wrong.
|
I don't want to steal your thunder but I was going through my open pull requests and I realized I made pretty much the same changes in #5458. |
Sorry, something went wrong.
|
Fine for me. :) closing in favour for #5458 |
Sorry, something went wrong.
Checklist
Affected core subsystem(s)
build
Description of change
Just for housekeeping and less confusion, we could get rid of unused code in js2c.py. I didn't see any use of those parts at least and can originate it back to commit 63a9cd3
I dug into this part of the build process and wanted to rewrite js2c.py in JS, which is fairly trivial now, as opposed to 2009. But those parts are just not necessary - pending CI.