FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

build: Fix compile failure in backtrace_posix.cc by mhdawson · Pull Request #7544 · nodejs/node · GitHub

/ node Public

build: Fix compile failure in backtrace_posix.cc - #7544

Closed
mhdawson wants to merge 1 commit into
nodejs:masterfrom
mhdawson:aixstack
ConversationCommits (1)ChecksFiles changed
Closed

build: Fix compile failure in backtrace_posix.cc#7544
mhdawson wants to merge 1 commit into
nodejs:masterfrom
mhdawson:aixstack

Conversation

mhdawson commented Jul 5, 2016

Copy link
Copy Markdown
Member
Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

core

Description of change

Fix compile failure in backtrace_posix.c on AIX introduced by #6734

build: Fix compile failure in backtrace_posix.cc
ee3ed0f 
Fix compile failure in backtrace_posix.c on AIX
nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Jul 5, 2016
mhdawson mentioned this pull request Jul 5, 2016
Closed

mhdawson commented Jul 5, 2016

Copy link
Copy Markdown
Member Author

@bnoordhuis

mhdawson commented Jul 5, 2016

Copy link
Copy Markdown
Member Author

CI run https://ci.nodejs.org/job/node-test-pull-request/3181/

cjihrig commented Jul 5, 2016

Copy link
Copy Markdown
Contributor

LGTM

mhdawson commented Jul 5, 2016

Copy link
Copy Markdown
Member Author

Going to land this once the CI run completes since it fixes a build break and the change is small and have one LGTM altready.

bnoordhuis commented Jul 5, 2016

Copy link
Copy Markdown
Member

LGTM

1 similar comment

mscdex commented Jul 5, 2016

Copy link
Copy Markdown
Contributor

LGTM

mhdawson commented Jul 5, 2016

Copy link
Copy Markdown
Member Author

CI is good landing

mhdawson commented Jul 5, 2016

Copy link
Copy Markdown
Member Author

Landed as 95a3c8f

mhdawson added a commit that referenced this pull request Jul 5, 2016
build: Fix compile failure in backtrace_posix.cc
95a3c8f 
Fix compile failure in backtrace_posix.c on AIX

Fixes: #7539
PR-URL: #7544
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Brian White <mscdex@mscdex.net>
mhdawson closed this Jul 5, 2016
Fishrock123 pushed a commit that referenced this pull request Jul 6, 2016
build: Fix compile failure in backtrace_posix.cc
5e4113e 
Fix compile failure in backtrace_posix.c on AIX

Fixes: #7539
PR-URL: #7544
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Brian White <mscdex@mscdex.net>
Fishrock123 mentioned this pull request Jul 6, 2016
Merged
MylesBorins mentioned this pull request Jul 11, 2016
Closed

MylesBorins commented Jul 12, 2016

Copy link
Copy Markdown
Contributor

@mhdawson lts?

MylesBorins mentioned this pull request Jul 14, 2016
Merged

MylesBorins commented Jul 14, 2016

Copy link
Copy Markdown
Contributor

needs to be backported if #6734 is backported

mhdawson deleted the aixstack branch March 15, 2017 21:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL