FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: Only use the TR1 type_traits when targeting OSX<10.9 by ehsan · Pull Request #7778 · nodejs/node · GitHub

/ node Public

src: Only use the TR1 type_traits when targeting OSX<10.9 - #7778

Closed
ehsan wants to merge 1 commit into
nodejs:masterfrom
ehsan:osx109
ConversationCommits (1)ChecksFiles changed
Closed

src: Only use the TR1 type_traits when targeting OSX<10.9#7778
ehsan wants to merge 1 commit into
nodejs:masterfrom
ehsan:osx109

Conversation

ehsan commented Jul 17, 2016 •
edited
Loading

Copy link
Copy Markdown
Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

src

Description of change

Mac OSX 10.9 has switched to using libc++ by default. libc++
provides a C++11 <type_traits> implementation, so we only need
to use the TR1 version when targetting OSX 10.8 or 10.7.

This patch fixes build failures when using -mmacosx-version-min=10.9 to build Node.

nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Jul 17, 2016
ehsan mentioned this pull request Jul 17, 2016
Closed

bnoordhuis commented Jul 18, 2016

Copy link
Copy Markdown
Member

LGTM but can you make sure the first line of the commit log is <= 50 characters?

cjihrig commented Jul 18, 2016

Copy link
Copy Markdown
Contributor

LGTM

src: Only use TR1 type_traits on OSX<10.9
e53a723 
Mac OSX 10.9 has switched to using libc++ by default.  libc++
provides a C++11 <type_traits> implementation, so we only need
to use the TR1 version when targetting OSX 10.8 or 10.7.

ehsan commented Jul 21, 2016

Copy link
Copy Markdown
Author

LGTM but can you make sure the first line of the commit log is <= 50 characters?

Done!

bnoordhuis commented Jul 22, 2016

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/3382/

addaleax commented Jul 27, 2016

Copy link
Copy Markdown
Member

LGTM and CI was green, landing…

addaleax commented Jul 27, 2016

Copy link
Copy Markdown
Member

Landed in 34d58ce, thanks!

addaleax closed this Jul 27, 2016
addaleax pushed a commit that referenced this pull request Jul 27, 2016
src: Only use TR1 type_traits on OSX<10.9
34d58ce 
Mac OSX 10.9 has switched to using libc++ by default.  libc++
provides a C++11 <type_traits> implementation, so we only need
to use the TR1 version when targetting OSX 10.8 or 10.7.

PR-URL: #7778
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
cjihrig mentioned this pull request Aug 8, 2016
Closed
cjihrig pushed a commit that referenced this pull request Aug 10, 2016
src: Only use TR1 type_traits on OSX<10.9
63c62cc 
Mac OSX 10.9 has switched to using libc++ by default.  libc++
provides a C++11 <type_traits> implementation, so we only need
to use the TR1 version when targetting OSX 10.8 or 10.7.

PR-URL: #7778
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
cjihrig mentioned this pull request Aug 11, 2016
Merged

MylesBorins commented Sep 30, 2016

Copy link
Copy Markdown
Contributor

this is not landing cleanly and blocked by some other util changes that I believe start with #6734

/cc @bnoordhuis

bnoordhuis commented Oct 2, 2016

Copy link
Copy Markdown
Member

I won't object to someone back-porting this patch but it's not necessary for v4.x releases, they are built with -mmacosx-version-min=10.7.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL