FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: typo added missing semicolons by ravindrabarthwal · Pull Request #7911 · nodejs/node · GitHub

/ node Public

doc: typo added missing semicolons - #7911

Closed
ravindrabarthwal wants to merge 1 commit into
nodejs:v4.xfrom
ravindrabarthwal:v4.x
ConversationCommits (1)ChecksFiles changed
Closed

doc: typo added missing semicolons#7911
ravindrabarthwal wants to merge 1 commit into
nodejs:v4.xfrom
ravindrabarthwal:v4.x

Conversation

ravindrabarthwal commented Jul 28, 2016

Copy link
Copy Markdown
Contributor
Description of change

Added missing semicolons to some missing places on the assert.mardown

doc: typo added missing semicolons
689ae48 
Added missing semicolons to some places on the assert.mardown
nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jul 28, 2016

claudiorodriguez commented Jul 28, 2016

Copy link
Copy Markdown
Contributor

LGTM

mscdex commented Jul 28, 2016

Copy link
Copy Markdown
Contributor

Are you sure this applies only to v4.x and not the master branch? Typically almost all changes happen in master first, then they get backported as necessary.

ravindrabarthwal commented Jul 28, 2016

Copy link
Copy Markdown
Contributor Author

I was reading the doc for assert module for v4.x branch and then found missing semicolons in some examples and thought to open pull request.

mscdex commented Jul 28, 2016

Copy link
Copy Markdown
Contributor

The first two changes were fixed recently in master with #7745. I have marked that PR for backporting. The last change is still missing in master though, would you mind instead opening a PR against master to fix that particular line? Then we can backport that as well.

ravindrabarthwal commented Jul 29, 2016

Copy link
Copy Markdown
Contributor Author

Sure!

mscdex closed this Jul 29, 2016

mscdex commented Jul 29, 2016

Copy link
Copy Markdown
Contributor

Thanks!

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL