doc: fix broken links in changelogs - #8122
Merged
evanlucas merged 1 commit intoOct 11, 2016
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
LGTM |
Sorry, something went wrong.
1 similar comment
Copy link
Copy Markdown
Member
|
LGTM |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Those are not all of affected commits. Here are a bit more of those: doc/changelogs/CHANGELOG_IOJS.md:1362:* [[`af9fe3bbc7`](https://github.com/nodejs/node/commit/af9fe3bbc7)] - **(SEMVER-MAJOR)** **src**: bump NODE_MODULE_VERSION due to V8 API (Rod Vagg) [#1532](https://github.com/nodejs/node/pull/1532)
doc/changelogs/CHANGELOG_IOJS.md:1446:* [[`2b744b0ab7`](https://github.com/nodejs/node/commit/2b744b0ab7)] - **src**: revert NODE_MODULE_VERSION to 43 (Chris Dickinson) [#1460](https://github.com/nodejs/node/pull/1460)
doc/changelogs/CHANGELOG_IOJS.md:666:* [[`52b1230628`](https://github.com/nodejs/node/commit/52b1230628)] - **deps**: update deps/openssl/conf/arch/*/opensslconf.h (Shigeki Ohtsu) [#2141](https://github.com/nodejs/node/pull/2141)
doc/changelogs/CHANGELOG_IOJS.md:667:* [[`20ff1e2ecb`](https://github.com/nodejs/node/commit/20ff1e2ecb)] - **deps**: upgrade openssl sources to 1.0.2d (Shigeki Ohtsu) [#2141](https://github.com/nodejs/node/pull/2141)
doc/changelogs/CHANGELOG_V4.md:1222:* [[`3dd90ddc73`](https://github.com/nodejs/node/commit/3dd90ddc73)] - **deps**: upgrade to npm 2.14.12 (Kat Marchán) [#4110](https://github.com/nodejs/node/pull/4110)
doc/changelogs/CHANGELOG_V5.md:291:* [[`e1a012f277`](https://github.com/nodejs/node/commit/e1a012f277)] - **deps**: upgrade npm to 3.8.3 (Forrest L Norvell)
doc/changelogs/CHANGELOG_V5.md:303:* [[`aac9ead379`](https://github.com/nodejs/node/commit/aac9ead379)] - **etw,build**: always generate .rc and .h files (João Reis) [#5657](https://github.com/nodejs/node/pull/5657)
doc/changelogs/CHANGELOG_V5.md:305:* [[`ae15d68ad1`](https://github.com/nodejs/node/commit/ae15d68ad1)] - **governance**: remove target size for CTC (Rich Trott) [#5879](https://github.com/nodejs/node/pull/5879)
doc/changelogs/CHANGELOG_V5.md:307:* [[`40847b0b8b`](https://github.com/nodejs/node/commit/40847b0b8b)] - **lib**: rename /node.js to /bootstrap_node.js (Jeremiah Senkpiel) [#5103](https://github.com/nodejs/node/pull/5103)
doc/changelogs/CHANGELOG_V5.md:308:* [[`e644eb3d69`](https://github.com/nodejs/node/commit/e644eb3d69)] - **lib**: refactor code with startsWith/endsWith (Jackson Tian) [#5753](https://github.com/nodejs/node/pull/5753)
doc/changelogs/CHANGELOG_V5.md:309:* [[`a757e0583c`](https://github.com/nodejs/node/commit/a757e0583c)] - **lib,src**: move src/node.js to lib/internal/node.js (Jeremiah Senkpiel) [#5103](https://github.com/nodejs/node/pull/5103)
doc/changelogs/CHANGELOG_V5.md:310:* [[`e3c7b46326`](https://github.com/nodejs/node/commit/e3c7b46326)] - **lib,src**: refactor src/node.js into internal files (Jeremiah Senkpiel) [#5103](https://github.com/nodejs/node/pull/5103)
doc/changelogs/CHANGELOG_V5.md:312:* [[`2fa959be15`](https://github.com/nodejs/node/commit/2fa959be15)] - **(SEMVER-MINOR)** **node**: --no-browser-globals configure flag (Fedor Indutny) [#5853](https://github.com/nodejs/node/pull/5853)
doc/changelogs/CHANGELOG_V5.md:315:* [[`d044898495`](https://github.com/nodejs/node/commit/d044898495)] - **src**: Add missing `using v8::MaybeLocal` (Anna Henningsen) [#5974](https://github.com/nodejs/node/pull/5974)
doc/changelogs/CHANGELOG_V5.md:319:* [[`8e8768ecbb`](https://github.com/nodejs/node/commit/8e8768ecbb)] - **test**: add known_issues test for GH-2148 (Rich Trott) [#5920](https://github.com/nodejs/node/pull/5920)
doc/changelogs/CHANGELOG_V5.md:320:* [[`bf94b5a1b9`](https://github.com/nodejs/node/commit/bf94b5a1b9)] - **test**: mitigate flaky test-https-agent (Rich Trott) [#5939](https://github.com/nodejs/node/pull/5939)
doc/changelogs/CHANGELOG_V5.md:321:* [[`2192528326`](https://github.com/nodejs/node/commit/2192528326)] - **test**: fix flaky test-repl (Brian White) [#5914](https://github.com/nodejs/node/pull/5914)
doc/changelogs/CHANGELOG_V5.md:773:* [[`d5d2f86f89`](https://github.com/nodejs/node/commit/d5d2f86f89)] - **(SEMVER-MINOR)** **deps**: update http-parser to version 2.6.1 (James M Snell)
doc/changelogs/CHANGELOG_V5.md:830:* [[`a3b84a4c93`](https://github.com/nodejs/node/commit/a3b84a4c93)] - **(SEMVER-MINOR)** **http**: strictly forbid invalid characters from headers (James M Snell)
doc/changelogs/CHANGELOG_V5.md:844:* [[`ac6627a0fe`](https://github.com/nodejs/node/commit/ac6627a0fe)] - **src**: avoid compiler warning in node_revert.cc (James M Snell)
doc/changelogs/CHANGELOG_V5.md:845:* [[`459c5844c8`](https://github.com/nodejs/node/commit/459c5844c8)] - **(SEMVER-MINOR)** **src**: add --security-revert command line flag (James M Snell)
doc/changelogs/CHANGELOG_V5.md:942:* [[`d56e3f8b67`](https://github.com/nodejs/node/commit/d56e3f8b67)] - **doc**: restore ICU third-party software licenses (Richard Lau) [#4762](https://github.com/nodejs/node/pull/4762)
doc/changelogs/CHANGELOG_V5.md:969:* [[`1a6e7d1b52`](https://github.com/nodejs/node/commit/1a6e7d1b52)] - **src**: fix negative values in process.hrtime() (Ben Noordhuis) [#4757](https://github.com/nodejs/node/pull/4757)
doc/changelogs/CHANGELOG_V5.md:972:* [[`953f4a3999`](https://github.com/nodejs/node/commit/953f4a3999)] - **stream**: prevent object map change in ReadableState (Evan Lucas) [#4761](https://github.com/nodejs/node/pull/4761)
doc/changelogs/CHANGELOG_V5.md:975:* [[`47960a07c0`](https://github.com/nodejs/node/commit/47960a07c0)] - **test**: make test-cluster-disconnect-leak reliable (Rich Trott) [#4736](https://github.com/nodejs/node/pull/4736)
doc/changelogs/CHANGELOG_V5.md:976:* [[`9926b5a25f`](https://github.com/nodejs/node/commit/9926b5a25f)] - **test**: fix issues for space-in-parens ESLint rule (Roman Reiss) [#4753](https://github.com/nodejs/node/pull/4753)
doc/changelogs/CHANGELOG_V5.md:984:* [[`c33f6a87d0`](https://github.com/nodejs/node/commit/c33f6a87d0)] - **tools**: enable space-in-parens ESLint rule (Roman Reiss) [#4753](https://github.com/nodejs/node/pull/4753)
doc/changelogs/CHANGELOG_V5.md:990:* [[`aba3cc834e`](https://github.com/nodejs/node/commit/aba3cc834e)] - **tools**: fix license-builder.sh for ICU (Richard Lau) [#4762](https://github.com/nodejs/node/pull/4762) |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Not all of those links are broken (some are, some aren't), but those commits are not present in the main tree, so even the link which work now could go away sometime. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
These links are broken atm: doc/changelogs/CHANGELOG_IOJS.md:1446:* [[`2b744b0ab7`](https://github.com/nodejs/node/commit/2b744b0ab7)] - **src**: revert NODE_MODULE_VERSION to 43 (Chris Dickinson) [#1460](https://github.com/nodejs/node/pull/1460)
doc/changelogs/CHANGELOG_V5.md:773:* [[`d5d2f86f89`](https://github.com/nodejs/node/commit/d5d2f86f89)] - **(SEMVER-MINOR)** **deps**: update http-parser to version 2.6.1 (James M Snell)
doc/changelogs/CHANGELOG_V5.md:830:* [[`a3b84a4c93`](https://github.com/nodejs/node/commit/a3b84a4c93)] - **(SEMVER-MINOR)** **http**: strictly forbid invalid characters from headers (James M Snell)
doc/changelogs/CHANGELOG_V5.md:844:* [[`ac6627a0fe`](https://github.com/nodejs/node/commit/ac6627a0fe)] - **src**: avoid compiler warning in node_revert.cc (James M Snell)
doc/changelogs/CHANGELOG_V5.md:845:* [[`459c5844c8`](https://github.com/nodejs/node/commit/459c5844c8)] - **(SEMVER-MINOR)** **src**: add --security-revert command line flag (James M Snell)The other ones could be broken later and also should be fixed. |
Sorry, something went wrong.
evanlucas
force-pushed
the
clarchivelinks
branch
from
3de1546 to
dda3ed6
Compare
August 17, 2016 10:56
Copy link
Copy Markdown
Contributor
Author
|
@ChALkeR I updated with fixes to address your last comment. I'll look more into the first list of commits shortly |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
@evanlucas ... ping ... what's the status on this one? |
Sorry, something went wrong.
evanlucas
force-pushed
the
clarchivelinks
branch
from
dda3ed6 to
2d2321c
Compare
September 18, 2016 12:21
Copy link
Copy Markdown
Contributor
Author
|
ok just pushed a bunch more updates, I'll be going through to double check this week so hopefully we can get all of the broken links fixed |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Do you want to hold off landing this then until you've done the other checks? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
This should be good to go, but I'm not sure if @ChALkeR has a better way to check than me or not? :] |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Just some grep magic. I can't find these commits in the tree: doc/changelogs/CHANGELOG_V5.md:969:* [[`1a6e7d1b52`](https://github.com/nodejs/node/commit/1a6e7d1b52)] - **src**: fix negative values in process.hrtime() (Ben Noordhuis) [#4757](https://github.com/nodejs/node/pull/4757) doc/changelogs/CHANGELOG_V5.md:321:* [[`2192528326`](https://github.com/nodejs/node/commit/2192528326)] - **test**: fix flaky test-repl (Brian White) [#5914](https://github.com/nodejs/node/pull/5914) doc/changelogs/CHANGELOG_V5.md:975:* [[`47960a07c0`](https://github.com/nodejs/node/commit/47960a07c0)] - **test**: make test-cluster-disconnect-leak reliable (Rich Trott) [#4736](https://github.com/nodejs/node/pull/4736) doc/changelogs/CHANGELOG_V5.md:319:* [[`8e8768ecbb`](https://github.com/nodejs/node/commit/8e8768ecbb)] - **test**: add known_issues test for GH-2148 (Rich Trott) [#5920](https://github.com/nodejs/node/pull/5920) doc/changelogs/CHANGELOG_V5.md:972:* [[`953f4a3999`](https://github.com/nodejs/node/commit/953f4a3999)] - **stream**: prevent object map change in ReadableState (Evan Lucas) [#4761](https://github.com/nodejs/node/pull/4761) doc/changelogs/CHANGELOG_V5.md:976:* [[`9926b5a25f`](https://github.com/nodejs/node/commit/9926b5a25f)] - **test**: fix issues for space-in-parens ESLint rule (Roman Reiss) [#4753](https://github.com/nodejs/node/pull/4753) doc/changelogs/CHANGELOG_V5.md:990:* [[`aba3cc834e`](https://github.com/nodejs/node/commit/aba3cc834e)] - **tools**: fix license-builder.sh for ICU (Richard Lau) [#4762](https://github.com/nodejs/node/pull/4762) doc/changelogs/CHANGELOG_V5.md:320:* [[`bf94b5a1b9`](https://github.com/nodejs/node/commit/bf94b5a1b9)] - **test**: mitigate flaky test-https-agent (Rich Trott) [#5939](https://github.com/nodejs/node/pull/5939) doc/changelogs/CHANGELOG_V5.md:984:* [[`c33f6a87d0`](https://github.com/nodejs/node/commit/c33f6a87d0)] - **tools**: enable space-in-parens ESLint rule (Roman Reiss) [#4753](https://github.com/nodejs/node/pull/4753) doc/changelogs/CHANGELOG_V5.md:315:* [[`d044898495`](https://github.com/nodejs/node/commit/d044898495)] - **src**: Add missing `using v8::MaybeLocal` (Anna Henningsen) [#5974](https://github.com/nodejs/node/pull/5974) doc/changelogs/CHANGELOG_V5.md:942:* [[`d56e3f8b67`](https://github.com/nodejs/node/commit/d56e3f8b67)] - **doc**: restore ICU third-party software licenses (Richard Lau) [#4762](https://github.com/nodejs/node/pull/4762) |
Sorry, something went wrong.
evanlucas
force-pushed
the
clarchivelinks
branch
from
2d2321c to
9a6a029
Compare
October 3, 2016 13:12
Copy link
Copy Markdown
Contributor
Author
|
Thanks @ChALkeR! Those are now fixed as well |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
LGTM |
Sorry, something went wrong.
jasnell
approved these changes
Oct 6, 2016
Some commit links in the changelogs were pointing to incorrect/missing shas. PR-URL: nodejs#8122 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
evanlucas
force-pushed
the
clarchivelinks
branch
from
9a6a029 to
3d54ea4
Compare
October 11, 2016 21:50
jasnell
pushed a commit
that referenced
this pull request
Oct 12, 2016
Some commit links in the changelogs were pointing to incorrect/missing shas. PR-URL: #8122 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 11, 2016
Some commit links in the changelogs were pointing to incorrect/missing shas. PR-URL: #8122 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc
Description of change
Some commit links in the changelogs were pointing to incorrect/missing
shas.