FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: unbreak build when compiling against uclibc by bnoordhuis · Pull Request #8308 · nodejs/node · GitHub

/ node Public

src: unbreak build when compiling against uclibc - #8308

Merged
bnoordhuis merged 1 commit into
nodejs:masterfrom
bnoordhuis:fix8233
Sep 5, 2016
ConversationCommits (1)ChecksFiles changed
Merged

src: unbreak build when compiling against uclibc#8308
bnoordhuis merged 1 commit into
nodejs:masterfrom
bnoordhuis:fix8233

Conversation

bnoordhuis commented Aug 28, 2016

Copy link
Copy Markdown
Member

It seems that it is possible with some toolchains for both __GLIBC__
and __UCLIBC__ to be defined, confusing our "do we have execinfo.h?"
logic.

Assume that when __UCLIBC__ is defined, we are dealing with a libc
that does not have execinfo.h.

Fixes: #8233

bnoordhuis added the c++ Issues and PRs that require attention from people who are familiar with C++. label Aug 28, 2016

cjihrig commented Aug 28, 2016

Copy link
Copy Markdown
Contributor

LGTM

jbergstroem commented Aug 28, 2016 •
edited
Loading

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-commit/4810/
Additional test against musl: https://ci.nodejs.org/job/node-test-commit-jbergstroem-alpine34/11/ (execinfo doesn't exist on musl either)

jasnell commented Aug 30, 2016

Copy link
Copy Markdown
Member

LGTM

src: unbreak build when compiling against uclibc
a290ddf 
It seems that it is possible with some toolchains for both `__GLIBC__`
and `__UCLIBC__` to be defined, confusing our "do we have execinfo.h?"
logic.

Assume that when `__UCLIBC__` is defined, we are dealing with a libc
that does not have execinfo.h.

Fixes: nodejs#8233
PR-URL: nodejs#8308
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
bnoordhuis closed this Sep 5, 2016
bnoordhuis deleted the fix8233 branch September 5, 2016 08:23
bnoordhuis merged commit a290ddf into nodejs:master Sep 5, 2016
Fishrock123 mentioned this pull request Sep 6, 2016
Closed
Fishrock123 pushed a commit to Fishrock123/node that referenced this pull request Sep 8, 2016
src: unbreak build when compiling against uclibc
850ce1d 
It seems that it is possible with some toolchains for both `__GLIBC__`
and `__UCLIBC__` to be defined, confusing our "do we have execinfo.h?"
logic.

Assume that when `__UCLIBC__` is defined, we are dealing with a libc
that does not have execinfo.h.

Fixes: nodejs#8233
PR-URL: nodejs#8308
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Fishrock123 pushed a commit that referenced this pull request Sep 9, 2016
src: unbreak build when compiling against uclibc
2c2a21a 
It seems that it is possible with some toolchains for both `__GLIBC__`
and `__UCLIBC__` to be defined, confusing our "do we have execinfo.h?"
logic.

Assume that when `__UCLIBC__` is defined, we are dealing with a libc
that does not have execinfo.h.

Fixes: #8233
PR-URL: #8308
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins commented Sep 30, 2016

Copy link
Copy Markdown
Contributor

@bnoordhuis backport to v4?

bnoordhuis commented Oct 1, 2016

Copy link
Copy Markdown
Member Author

Yes.

MylesBorins commented Oct 11, 2016

Copy link
Copy Markdown
Contributor

@bnoordhuis src/backtrace_posix.cc does not exist on v4.x. The source also does not appear to be present. Am I missing something?

bnoordhuis commented Oct 11, 2016

Copy link
Copy Markdown
Member Author

Sorry, it depends on #6734 which is tagged but not back-ported yet. I don't know if or when I'll get around to that.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL