| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Replace the current limit of 50 characters for the first line of the commit message with a more flexible formulation.
|
I'm -1. Can only assume there will be a lot of opinions here, so I'll try to at least elaborate my thoughts:
|
Sorry, something went wrong.
|
I can totally relate to the problem of child_process: taking up most a fair amount of the available characters, but I think I'm -1 due to @jbergstroem's 1st and 3rd points. |
Sorry, something went wrong.
|
Okay, given to the number of -1’s/downvotes, I’m inclined to close this a bit later. Thanks @jbergstroem for naming a few reasons for the limit!
True, but that’s only a concern when actively using merge commits instead of rebasing/cherry-picking, is it?
It’s 70.
Interesting, I didn’t know that. |
Sorry, something went wrong.
|
From git commit help:
But that still doesn't really explain why 50 is the sweet spot. |
Sorry, something went wrong.
It's 72, and it's a fair limit imho. |
Sorry, something went wrong.
It displays well in text-only email clients. Git started out in the linux kernel community and their workflow is built around email (and terminals.) |
Sorry, something went wrong.
|
While it's true that the manpage suggests a limit of 50 chars it is also true that the Linux Kernel documentation does not impose such limit.
It would be great to have a soft limit of 50 chars and an hard limit of 70? chars but then I understand that it would be hard to make people respect the soft limit.
This can help and is a totally valid point. |
Sorry, something went wrong.
|
Given the number of downvotes, I’m closing this. Thanks everyone for explaining where your opinions come from! |
Sorry, something went wrong.
|
2 👍 vs. 3 👎 |
Sorry, something went wrong.
|
@addaleax you closed it in two days, I'm with @ronkorving IMHO the git manual is not a strong argument as it is legacy more than lore. |
Sorry, something went wrong.
|
@refack I’m not stopping anybody from picking this up again, but my energy for pushing contentious issues is limited and I prefer to keep it for things that matter more to me than this. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Replace the current limit of 50 characters for the first line of the commit message with a more flexible formulation.
Copying the reasoning from #8294 (comment):
50 characters is a pretty hard limit when you need to include something like child_process: and/or are a non-native speaker with reduced vocabulary.