FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: update authors list again by jasnell · Pull Request #8346 · nodejs/node · GitHub

/ node Public

doc: update authors list again - #8346

Closed
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:update-authors-2
ConversationCommits (1)ChecksFiles changed
Closed

doc: update authors list again#8346
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:update-authors-2

Conversation

jasnell commented Aug 30, 2016

Copy link
Copy Markdown
Member
Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

Another round of AUTHORS.md updates. This is an initial take. The list needs to be cleaned with duplicates removed and real names added. Help is appreciated! :-) /cc @nodejs/collaborators

Note: All of the edits on this were generated automatically by the update-authors tool. It's quite likely that there are incorrect edits.

jasnell added doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. labels Aug 30, 2016
ChALkeR reviewed Aug 30, 2016
View reviewed changes
Comment thread AUTHORS Outdated

ChALkeR Aug 30, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Is this done on a purpose?

jasnell Aug 30, 2016

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

nope... the update-authors tool changed a bunch of these. I'm changing them back

rumkin commented Sep 1, 2016

Copy link
Copy Markdown
Contributor

@jasnell Rumkin is ok.

jasnell commented Sep 2, 2016

Copy link
Copy Markdown
Member Author

Ok, @nodejs/collaborators ... I think this is ready to go. PTAL

addaleax reviewed Sep 2, 2016
View reviewed changes
Comment thread AUTHORS Outdated

addaleax Sep 2, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

yay, I’m duplicate! 😄 (this one is the one which should be removed)

jasnell Sep 2, 2016

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

ha! I thought I caught all of those. thanks! :-)

jasnell Sep 2, 2016

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Fixed!

addaleax commented Sep 2, 2016

Copy link
Copy Markdown
Member

LGTM! :)

silverwind commented Sep 2, 2016 •
edited
Loading

Copy link
Copy Markdown
Contributor

@jasnell why not edit .mailmap so you don't have to do the same manual changes the next time?

jasnell commented Sep 2, 2016

Copy link
Copy Markdown
Member Author

heh... that would make far too much sense ;-) ... good idea!

jasnell mentioned this pull request Sep 2, 2016
Closed
2 tasks

jasnell commented Sep 2, 2016

Copy link
Copy Markdown
Member Author

@ChALkeR ... does this LGTY?
@nodejs/collaborators ... anyone else?

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Back | FazBrowse Home | New Git URL