process: fix handling of process.noDeprecation in emitWarning - #8394
Closed
jasnell wants to merge 1 commit into
Closed
process: fix handling of process.noDeprecation in emitWarning#8394jasnell wants to merge 1 commit into
jasnell wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Cherry-picked from: PR-URL: nodejs#8166 Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
Copy link
Copy Markdown
Member
Author
|
@thealphanerd @ChALkeR ... PTAL |
Sorry, something went wrong.
addaleax
approved these changes
Sep 24, 2016
addaleax
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM, although this should probably target v6.x-staging now?
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Agreed. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Landed in e097a50. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
process
Description of change
Cherry-pick of process: fix handling of process.noDeprecation in emitWarning from:
PR-URL: #8166
Reviewed-By: Сковорода Никита Андреевич chalkerx@gmail.com
Reviewed-By: Myles Borins myles.borins@gmail.com