FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

inspector: fix tests on Windows by eugeneo · Pull Request #8528 · nodejs/node · GitHub

/ node Public

inspector: fix tests on Windows - #8528

Closed
eugeneo wants to merge 1 commit into
nodejs:masterfrom
eugeneo:tests
ConversationCommits (1)ChecksFiles changed
Closed

inspector: fix tests on Windows#8528
eugeneo wants to merge 1 commit into
nodejs:masterfrom
eugeneo:tests

Conversation

eugeneo commented Sep 14, 2016 •
edited
Loading

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

Inspector protocol implementation & test

Description of change

Should help with #8034

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. inspector Issues and PRs related to the V8 inspector protocol labels Sep 14, 2016
eugeneo mentioned this pull request Sep 14, 2016
Merged
mscdex added the windows Issues and PRs related to the Windows platform. label Sep 14, 2016
bnoordhuis reviewed Sep 14, 2016
View reviewed changes
Comment thread test/cctest/test_inspector_socket.cc Outdated

bnoordhuis Sep 14, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Can you write it as uv_stream_t* (no space) while you're here?

eugeneo Sep 14, 2016

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Updated this location and several similar ones.

bnoordhuis commented Sep 14, 2016

Copy link
Copy Markdown
Member

LGTM

eugeneo commented Sep 14, 2016

Copy link
Copy Markdown
Contributor Author

Thank you for the review. Commit was updated.

eugeneo commented Sep 14, 2016

Copy link
Copy Markdown
Contributor Author

@ofrobots

ofrobots commented Sep 15, 2016

Copy link
Copy Markdown
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/4065/

ofrobots commented Sep 16, 2016

Copy link
Copy Markdown
Contributor

The AIX build failure looked mysterious; relaunched: https://ci.nodejs.org/job/node-test-commit-aix/861/.

ofrobots commented Sep 16, 2016

Copy link
Copy Markdown
Contributor

CI is green enough. AIX rebuild was successful and the arm-fanned failure looks like a bot issue.

ofrobots commented Sep 16, 2016

Copy link
Copy Markdown
Contributor

Landed as 6f9157f.

ofrobots closed this Sep 16, 2016
ofrobots pushed a commit that referenced this pull request Sep 16, 2016
inspector: fix tests on Windows
6f9157f 
Should help with #8034.

PR-URL: #8528
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
eugeneo deleted the tests branch September 16, 2016 17:16
MylesBorins pushed a commit to MylesBorins/node that referenced this pull request Sep 28, 2016
inspector: fix tests on Windows
4ee840e 
Should help with nodejs#8034.

PR-URL: nodejs#8528
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
MylesBorins pushed a commit that referenced this pull request Sep 30, 2016
inspector: fix tests on Windows
3222b66 
Should help with #8034.

PR-URL: #8528
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. inspector Issues and PRs related to the V8 inspector protocol windows Issues and PRs related to the Windows platform.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL