src: Add does_zap_garbage to v8 HeapStatistics by gareth-ellis · Pull Request #8610 · nodejs/node · GitHub

Checklist

make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

Affected core subsystem(s) src, doc

Description of change

Following nodejs/code-and-learn#56 I have exposed does_zap_garbage to HeapStatistics.
The other fields, malloced_memory and peak_malloced_memory don't seem to be in the current version of v8 in master.

I have also updated the docs and test so that it matches the

I think this should be {number} instead, if we're not actually returning a boolean type (true or false).

Ack, although it might be nice to have a short description here saying that this does return a 0/1 boolean.

I don't think it's all that useful without explaining why it matters if garbage is getting zapped or not.

--zap_code_space makes V8 overwrite heap garbage with a bit pattern. The RSS footprint (resident memory set) gets bigger because it continuously touches all heap pages and that makes them less likely to get swapped out by the operating system.

LGTM with the requested doc change and CI of course.

CI: https://ci.nodejs.org/job/node-test-pull-request/4089/

The other fields, malloced_memory and peak_malloced_memory don't seem to be in the current version of v8 in master.

Yeah, I guess that counts as my bad. The other fields would come in with #8317 – Since it looks like that one is going to land soon, it seems reasonable to leave this PR open until #8317 is merged and it can be updated with all of the fields that are going to be in v7?

I'll keep an eye on #8317 and push the changes once that's landed and I've tested the extra two fields.

The ci run fail seems like it could be some machine issues. It'll need rerunning once the extra changes go in anyway....

I'll keep an eye on #8317 and push the changes once that's landed and I've tested the extra two fields.

Great! It should really not take long (I’m marking this as blocked for the time being).

The ci run fail seems like it could be some machine issues. It'll need rerunning once the extra changes go in anyway....

Yeah, it’s only machine issues, don’t worry about it. We’ll run CI again when this is ready. :)

@gareth-ellis The other fields are available on master now, so this should no longer be blocked. \o/

Updated to reflect the new fields being added to v8. ptal

CI: https://ci.nodejs.org/job/node-test-commit/5244/

LGTM if it’s green. It would be ideal if you could use a one-line commit subject, e.g. v8: extend HeapStatistics with new fields?

Done, I kept src as the subsystem, hope that's ok

LGTM with nits.

Can you put does_zap_garbage and zap_code_space between backticks and put two dashes before the latter? People will have a hard time guessing it's a command line switch otherwise.

Nit: no initial space.

src: Add does_zap_garbage, malloced_memory and peak_malloced_memory to v8 HeapStatistics Following nodejs/code-and-learn#56 I have exposed does_zap_garbage to HeapStatistics. The other fields, malloced_memory and peak_malloced_memory don't seem to be in the current version of v8 in master.

Made changes to address @bnoordhuis 's comments

New CI: https://ci.nodejs.org/job/node-test-pull-request/4415/

Last CI was too red, trying again: https://ci.nodejs.org/job/node-test-pull-request/4425/

CI was green except for FreeBSD, so here’s one more try: https://ci.nodejs.org/job/node-test-commit/5503/

Seems the freebsd failiure is three timeouts. However, it seems to be failing more often than not

Sorry this got a bit lost, new CI: https://ci.nodejs.org/job/node-test-commit/6092/

Landed in 440057e, thanks for the PR!

src: Add does_zap_garbage, malloced_memory and peak_malloced_memory to v8 HeapStatistics Following nodejs/code-and-learn#56 I have exposed does_zap_garbage to HeapStatistics. The other fields, malloced_memory and peak_malloced_memory don't seem to be in the current version of v8 in master. PR-URL: #8610 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

Notable changes: * crypto: The `Decipher` methods `setAuthTag()` and `setAAD` now return `this`. (Kirill Fomichev) #9398 * dns: Implemented `{ttl: true}` for `resolve4()` and `resolve6()`. (Ben Noordhuis) #9296 & #9296 * libuv: Upgrade to v1.10.1 (cjihrig) #9647 * process: Added a new `external` property to the data returned by `memoryUsage()`. (Fedor Indutny) #9587 * V8 (dep): Upgrade to v5.4.500.43 (Michaël Zasso) #9697 * v8: The data returned by `getHeapStatistics()` now includes three new fields: `malloced_memory`, `peak_malloced_memory`, and `does_zap_garbage`. (Gareth Ellis) #8610 PR-URL: #9745

This is a security release impacting Windows 10 users. Notable changes: * crypto: The `Decipher` methods `setAuthTag()` and `setAAD` now return `this`. (Kirill Fomichev) #9398 * dns: Implemented `{ttl: true}` for `resolve4()` and `resolve6()`. (Ben Noordhuis) #9296 & #9296 * libuv: Upgrade to v1.10.1 (cjihrig) #9647 - Fixed a potential buffer overflow when writing data to console on Windows 10. (CVE-2016-9551) * process: Added a new `external` property to the data returned by `memoryUsage()`. (Fedor Indutny) #9587 * tls: Fixed a memory leak when writes were queued on TLS connection that was destroyed during handshake. (Fedor Indutny) #9626 * V8 (dep): Upgrade to v5.4.500.43 (Michaël Zasso) #9697 * v8: The data returned by `getHeapStatistics()` now includes three new fields: `malloced_memory`, `peak_malloced_memory`, and `does_zap_garbage`. (Gareth Ellis) #8610 PR-URL: #9745

This is a security release impacting Windows 10 users. Notable changes: * crypto: The `Decipher` methods `setAuthTag()` and `setAAD` now return `this`. (Kirill Fomichev) nodejs/node#9398 * dns: Implemented `{ttl: true}` for `resolve4()` and `resolve6()`. (Ben Noordhuis) nodejs/node#9296 & nodejs/node#9296 * libuv: Upgrade to v1.10.1 (cjihrig) nodejs/node#9647 - Fixed a potential buffer overflow when writing data to console on Windows 10. (CVE-2016-9551) * process: Added a new `external` property to the data returned by `memoryUsage()`. (Fedor Indutny) nodejs/node#9587 * tls: Fixed a memory leak when writes were queued on TLS connection that was destroyed during handshake. (Fedor Indutny) nodejs/node#9626 * V8 (dep): Upgrade to v5.4.500.43 (Michaël Zasso) nodejs/node#9697 * v8: The data returned by `getHeapStatistics()` now includes three new fields: `malloced_memory`, `peak_malloced_memory`, and `does_zap_garbage`. (Gareth Ellis) nodejs/node#8610 Signed-off-by: Ilkka Myller <ilkka.myller@nodefield.com>

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. v8 engine Issues and PRs related to the V8 dependency. labels Sep 17, 2016

mscdex reviewed Sep 17, 2016

View reviewed changes

addaleax added dont-land-on-v4.x labels Sep 17, 2016

cjihrig approved these changes Sep 17, 2016

View reviewed changes

Fishrock123 reviewed Sep 17, 2016

View reviewed changes

addaleax added the blocked PRs that are blocked by other issues or PRs. label Sep 17, 2016

Trott force-pushed the master branch from b0df363 to c5ce7f4 Compare September 21, 2016 00:10

addaleax removed the blocked PRs that are blocked by other issues or PRs. label Sep 22, 2016

addaleax added the semver-minor PRs that contain new features and should be released in the next minor version. label Sep 22, 2016

addaleax approved these changes Sep 22, 2016

View reviewed changes

bnoordhuis approved these changes Sep 23, 2016

View reviewed changes

jasnell self-assigned this Oct 6, 2016

rvagg force-pushed the master branch 2 times, most recently from c133999 to 83c7a88 Compare October 18, 2016 17:02

addaleax closed this Nov 20, 2016

addaleax unassigned jasnell Nov 20, 2016

Fishrock123 mentioned this pull request Nov 22, 2016

v7.2.0 proposal #9745

Merged

2 tasks

bnb mentioned this pull request Mar 11, 2020

Move to Electron's docs-parser tooling for Node.js documentation #32206

Closed

4 tasks

src: Add does_zap_garbage to v8 HeapStatistics by gareth-ellis · Pull Request #8610 · nodejs/node · GitHub

Uh oh!

Uh oh!

src: Add does_zap_garbage to v8 HeapStatistics - #8610

src: Add does_zap_garbage to v8 HeapStatistics#8610gareth-ellis wants to merge 1 commit intonodejs:masternodejs/node:masterfrom gareth-ellis:v8_statsCopy head branch name to clipboard

Conversation

gareth-ellis commented Sep 17, 2016

Checklist

Affected core subsystem(s) src, doc

Description of change

Uh oh!

mscdex Sep 17, 2016

Choose a reason for hiding this comment

Uh oh!

addaleax Sep 17, 2016

Choose a reason for hiding this comment

Uh oh!

bnoordhuis Sep 17, 2016

Choose a reason for hiding this comment

Uh oh!

cjihrig left a comment

Choose a reason for hiding this comment

Uh oh!

Fishrock123 left a comment

Choose a reason for hiding this comment

Uh oh!

addaleax commented Sep 17, 2016

Uh oh!

gareth-ellis commented Sep 17, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

addaleax commented Sep 17, 2016

Uh oh!

addaleax commented Sep 22, 2016

Uh oh!

gareth-ellis commented Sep 22, 2016

Uh oh!

addaleax left a comment

Choose a reason for hiding this comment

Uh oh!

gareth-ellis commented Sep 22, 2016

Uh oh!

bnoordhuis left a comment

Choose a reason for hiding this comment

Uh oh!

bnoordhuis Sep 23, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bnoordhuis Sep 23, 2016

Choose a reason for hiding this comment

Uh oh!

gareth-ellis commented Sep 23, 2016

Uh oh!

jasnell commented Oct 6, 2016

Uh oh!

jasnell commented Oct 7, 2016

Uh oh!

addaleax commented Oct 7, 2016

Uh oh!

gareth-ellis commented Oct 9, 2016

Uh oh!

addaleax commented Nov 20, 2016

Uh oh!

addaleax commented Nov 20, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

src: Add does_zap_garbage to v8 HeapStatistics#8610
gareth-ellis wants to merge 1 commit into
nodejs:masterfrom
gareth-ellis:v8_stats

gareth-ellis commented Sep 17, 2016 •
edited
Loading

bnoordhuis Sep 23, 2016 •
edited
Loading