FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

deps: fix icu-shrinker to handle ICU 58 by srl295 · Pull Request #8674 · nodejs/node · GitHub

/ node Public

deps: fix icu-shrinker to handle ICU 58 - #8674

Closed
srl295 wants to merge 1 commit into
nodejs:masterfrom
srl295:fix-icu-shrinker
ConversationCommits (1)ChecksFiles changed
Closed

deps: fix icu-shrinker to handle ICU 58#8674
srl295 wants to merge 1 commit into
nodejs:masterfrom
srl295:fix-icu-shrinker

Conversation

srl295 commented Sep 20, 2016

Copy link
Copy Markdown
Member
  • commit message follows commit guidelines
Affected core subsystem(s)
  • deps
Description of change

ICU’s license file changed from license.html to LICENSE.
Fix shrink-icu-src.py (which is manually run) to accept either file.

Related to #7844 which is the 58 bump.

deps: fix icu-shrinker to handle ICU 58
8847167 
ICU’s license file changed from `license.html` to `LICENSE`.
Fix `shrink-icu-src.py` (which is manually run) to accept either file.

Related to nodejs#7844 which is the 58 bump.
srl295 added tools Issues and PRs related to the tools directory. i18n-api Issues and PRs related to the i18n implementation. labels Sep 20, 2016
srl295 self-assigned this Sep 20, 2016
nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Sep 20, 2016
jbergstroem reviewed Sep 21, 2016
View reviewed changes
Comment thread tools/icu/shrink-icu-src.py
if 'license.html' in ign:
ign.remove('license.html')
if 'LICENSE' in ign:
ign.remove('LICENSE')

jbergstroem Sep 21, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

out of my head but perhaps if any(item in ign for item in('LICENSE', 'license.html'))

srl295 Oct 25, 2016

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks. I'm going to change the logic a bit here. We want to keep 'LICENSE' || 'license.html' in that order.

Comment thread tools/icu/shrink-icu-src.py
ign = ign + ['unidata','curr','zone','unit','lang','region','misc','sprep']
#elif subdir == 'source/data':
# ign = ign + ['unidata','curr','zone','unit','lang','region','misc','sprep']
# else:

jbergstroem Sep 21, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

remove?

srl295 Oct 25, 2016

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

yes, will remove. and the following comments.

rvagg force-pushed the master branch 2 times, most recently from c133999 to 83c7a88 Compare October 18, 2016 17:02

srl295 commented Oct 25, 2016

Copy link
Copy Markdown
Member Author

@jbergstroem I'm not sure where I ended up with this… but I'll revisit your comments now that #7844 is now in progress.

srl295 mentioned this pull request Oct 25, 2016
Closed
4 tasks

srl295 commented Oct 25, 2016

Copy link
Copy Markdown
Member Author

@jbergstroem I'm going to fold this into #9234 and close this PR.

srl295 closed this Oct 25, 2016
srl295 deleted the fix-icu-shrinker branch October 25, 2016 18:25
srl295 added a commit to srl295/node that referenced this pull request Oct 31, 2016
deps: Intl: ICU 58 bump: configure/LICENSE/docs
3c386db 
* bump to ICU 58.1 - update URL / hash
* does not attempt to reduce size - yet
* patch to work around http://bugs.icu-project.org/trac/ticket/12822
  ( compile issue on Windows)
* Fix ICU shrinker to delete old license.html file
  (update to nodejs#8674 )

Fixes: nodejs#7844
PR-URL: nodejs#9234
Reviewed-By: James M Snell <jasnell@gmail.com>
srl295 added a commit that referenced this pull request Oct 31, 2016
deps: Intl: ICU 58 bump: configure/LICENSE/docs
03023fa 
* bump to ICU 58.1 - update URL / hash
* does not attempt to reduce size - yet
* patch to work around http://bugs.icu-project.org/trac/ticket/12822
  ( compile issue on Windows)
* Fix ICU shrinker to delete old license.html file
  (update to #8674 )

Fixes: #7844
PR-URL: #9234
Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas pushed a commit that referenced this pull request Nov 3, 2016
deps: Intl: ICU 58 bump: configure/LICENSE/docs
827000e 
* bump to ICU 58.1 - update URL / hash
* does not attempt to reduce size - yet
* patch to work around http://bugs.icu-project.org/trac/ticket/12822
  ( compile issue on Windows)
* Fix ICU shrinker to delete old license.html file
  (update to #8674 )

Fixes: #7844
PR-URL: #9234
Reviewed-By: James M Snell <jasnell@gmail.com>
srl295 added a commit to srl295/node that referenced this pull request Jan 18, 2017
deps: Intl: ICU 58 bump: configure/LICENSE/docs
062948b 
* bump to ICU 58.1 - update URL / hash
* does not attempt to reduce size - yet
* patch to work around http://bugs.icu-project.org/trac/ticket/12822
  ( compile issue on Windows)
* Fix ICU shrinker to delete old license.html file
  (update to nodejs#8674 )

Fixes: nodejs#7844
PR-URL: nodejs#9234
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 20, 2017
deps: Intl: ICU 58 bump: configure/LICENSE/docs
5f93d7c 
* bump to ICU 58.1 - update URL / hash
* does not attempt to reduce size - yet
* patch to work around http://bugs.icu-project.org/trac/ticket/12822
  ( compile issue on Windows)
* Fix ICU shrinker to delete old license.html file
  (update to #8674 )

Fixes: #7844
PR-URL: #9234
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 24, 2017
deps: Intl: ICU 58 bump: configure/LICENSE/docs
964cf26 
* bump to ICU 58.1 - update URL / hash
* does not attempt to reduce size - yet
* patch to work around http://bugs.icu-project.org/trac/ticket/12822
  ( compile issue on Windows)
* Fix ICU shrinker to delete old license.html file
  (update to #8674 )

Fixes: #7844
PR-URL: #9234
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 31, 2017
deps: Intl: ICU 58 bump: configure/LICENSE/docs
0ee665c 
* bump to ICU 58.1 - update URL / hash
* does not attempt to reduce size - yet
* patch to work around http://bugs.icu-project.org/trac/ticket/12822
  ( compile issue on Windows)
* Fix ICU shrinker to delete old license.html file
  (update to #8674 )

Fixes: #7844
PR-URL: #9234
Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
jbergstroem jbergstroem left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

srl295

Labels

i18n-api Issues and PRs related to the i18n implementation. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL