deps: upgrade npm to 3.10.8 by zkat · Pull Request #8706 · nodejs/node · GitHub

Checklist

make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

Affected core subsystem(s)

deps

Description of change

Hey y'all!

I know it's been a while, since the npm CLI team moved to a monthly release cadence, but here's the latest and greatest in packaging technology!

Also! It might be of interest to y'all to know that the CLI team is planning to release npm@4 as our next latest with that October release. Of course, npm@3 will continue to be supported, since we're assuming it's what's gonna go into node@6 LTS. The breaking changes in npm@4 will be much less significant than those in npm@3 so it should have less impact overall. 👍

Notable Changes:

29cf56d npm/npm#8614 Include scoped packages in bundled dependencies. (@forivall)
b7f13bc npm/npm#13259 Run top level preinstall script before installing dependencies (@palmerj3)
7e0cdff npm/npm#13497 graceful-fs@4.1.5: graceful-fs had a bug fix which fixes a problem (nodejs/node#7846) exposed by recent changes to Node.js. (@thefourtheye)
9b88cb8 npm/npm#9984 request@2.74.0 (@zarenner) (@stash-sfdc)
- Update request library to at least 2.73 to fix a bug where npm install would crash with Cannot read property 'emit' of null.
- Update request dependency tough-cookie to 2.3.0 to to address https://nodesecurity.io/advisories/130. Versions 0.9.7 through 2.2.2 contain a vulnerable regular expression that, under certain conditions involving long strings of semicolons in the "Set-Cookie" header, causes the event loop to block for excessive amounts of time.
npm/npm#10073 npm/npm#10073 npm/npm#13692 npm/npm#11735 npm/npm#13394 npm/npm#12718 A series of fixes to shrinkwrap related to optionalDependencies, devDependencies, git dependencies, saving, tracking, etc. tl;dr shrinkwrap should be a lot more reliable now, specially with some corner cases around things that aren't just regular dependencies.
npm/npm-registry-client#142 Fix EventEmitter warning spam from error handlers on socket. (@addaleax)
A number of improvements to error reporting on the installer
Various bugfixes, including for some crashers
Doc updates
Other dependency updates

Changelogs

r: @thealphanerd
r: @addaleax

heads-up that there might be a test failure but I'm not sure why it's happening only on test-npm but I'll check that out tomorrow.

Edit: there was a thing with tap, and manually bumping to tap@7 fixed the issue. Next release will probably include that, but since it's just a testrunner issue. I've included a patch in this PR to that effect.

@zkat So all tests passed except for one, and that one was fixed by upgrading to tap@7?

@gibfahn all tests should pass. I pushed a patch that bumps the tap version. This PR should not have any failing tests.

git am fails with a conflict...?

curl -L https://github.com/nodejs/node/pull/8706.patch | git am
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   138    0   138    0     0    355      0 --:--:-- --:--:-- --:--:--   355
100 3817k    0 3817k    0     0  1490k      0 --:--:--  0:00:02 --:--:-- 1815k
Applying: deps: upgrade npm to 3.10.8
/Users/Jeremiah/Documents/node/.git/rebase-apply/patch:2388: trailing whitespace.
The `--ignore-scripts` argument will cause npm to not execute any 
/Users/Jeremiah/Documents/node/.git/rebase-apply/patch:2527: trailing whitespace.
3. Developer, works on packages they are given access to.  
/Users/Jeremiah/Documents/node/.git/rebase-apply/patch:2536: trailing whitespace.
* Grant access:  
/Users/Jeremiah/Documents/node/.git/rebase-apply/patch:2549: trailing whitespace.
default will only publish internally. 
/Users/Jeremiah/Documents/node/.git/rebase-apply/patch:3139: trailing whitespace.
<p>The <code>--ignore-scripts</code> argument will cause npm to not execute any 


error: deps/npm/node_modules/request/node_modules/form-data/README.md: already exists in working directory
Patch failed at 0001 deps: upgrade npm to 3.10.8


The copy of the patch that failed is found in:
   /Users/Jeremiah/Documents/node/.git/rebase-apply/patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Hmm, git am -3 seems to have worked. Running tests.

@Fishrock123 that's the casing bug again. It looks like my local copy of form-data's README is README.md (???), but the version in their repo is Readme.md (?!?!?!)

Siiiigh :\

Tests passing, LGTM

Thanks! Landed in 33aa953...6b443d1

PR-URL: #8706 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

* fs: - `SyncWriteStream` now inherits from `Stream.Writable`. (Anna Henningsen) #8830 - Practically, this means that when stdio is piped to a file, stdout and stderr will still be `Writable` streams. - `fs.existsSync()` has been undeprecated. `fs.exists()` remains deprecated. (Dan Fabulich) #8364 * http: `http.request()` now accepts a `timeout` option. (Rene Weber) #8101 * module: The module loader now maintains its own realpath cache. (Anna Henningsen) #8100 * npm: Upgraded to 3.10.8 (Kat Marchán) #8706 * stream: `Duplex` streams now show proper `instanceof Stream.Writable`. (Anna Henningsen) #8834 * timers: Improved `setTimeout`/`Interval` performance by up to 22%. (Brian White) #8661 PR-URL: #9034

* fs: - `SyncWriteStream` now inherits from `Stream.Writable`. (Anna Henningsen) nodejs/node#8830 - Practically, this means that when stdio is piped to a file, stdout and stderr will still be `Writable` streams. - `fs.existsSync()` has been undeprecated. `fs.exists()` remains deprecated. (Dan Fabulich) nodejs/node#8364 * http: `http.request()` now accepts a `timeout` option. (Rene Weber) nodejs/node#8101 * module: The module loader now maintains its own realpath cache. (Anna Henningsen) nodejs/node#8100 * npm: Upgraded to 3.10.8 (Kat Marchan) nodejs/node#8706 * stream: `Duplex` streams now show proper `instanceof Stream.Writable`. (Anna Henningsen) nodejs/node#8834 * timers: Improved `setTimeout`/`Interval` performance by up to 22%. (Brian White) nodejs/node#8661 Signed-off-by: Ilkka Myller <ilkka.myller@nodefield.com>

nodejs-github-bot added the npm Issues and PRs related to the npm client dependency or the npm registry. label Sep 22, 2016

Fishrock123 self-assigned this Sep 22, 2016

zkat added 2 commits September 22, 2016 08:00

deps: upgrade npm to 3.10.8

89490f1

deps: hotfix upgrade npm tap version to get tests working

99ec764

zkat force-pushed the npm-3.10.8 branch from 51133eb to 99ec764 Compare September 22, 2016 15:01

Fishrock123 closed this Sep 27, 2016

Fishrock123 pushed a commit that referenced this pull request Sep 27, 2016

deps: upgrade npm to 3.10.8

d44a9eb

PR-URL: #8706 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

Fishrock123 pushed a commit that referenced this pull request Sep 27, 2016

deps: hotfix upgrade npm tap version for tests

6b443d1

PR-URL: #8706 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

jasnell pushed a commit that referenced this pull request Sep 29, 2016

deps: upgrade npm to 3.10.8

089b289

PR-URL: #8706 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

jasnell pushed a commit that referenced this pull request Sep 29, 2016

deps: hotfix upgrade npm tap version for tests

bb0af88

PR-URL: #8706 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

MylesBorins pushed a commit that referenced this pull request Sep 29, 2016

deps: upgrade npm to 3.10.8

9ecfc32

PR-URL: #8706 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

MylesBorins pushed a commit that referenced this pull request Sep 29, 2016

deps: hotfix upgrade npm tap version for tests

4d41bd9

PR-URL: #8706 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

MylesBorins added the dont-land-on-v4.x label Sep 30, 2016

wraithgar deleted the npm-3.10.8 branch June 26, 2025 15:41

deps: upgrade npm to 3.10.8 by zkat · Pull Request #8706 · nodejs/node · GitHub

Uh oh!

Uh oh!

deps: upgrade npm to 3.10.8 - #8706

deps: upgrade npm to 3.10.8#8706
zkat wants to merge 2 commits into
nodejs:masterfrom
npm:npm-3.10.8

zkat commented Sep 22, 2016

Uh oh!

zkat commented Sep 22, 2016 •
edited
Loading

Uh oh!

Uh oh!

gibfahn commented Sep 22, 2016

Uh oh!

zkat commented Sep 22, 2016

Uh oh!

Fishrock123 commented Sep 22, 2016 •
edited
Loading

Uh oh!

Uh oh!

Fishrock123 commented Sep 22, 2016

Uh oh!

zkat commented Sep 22, 2016

Uh oh!

Fishrock123 commented Sep 22, 2016

Uh oh!

Fishrock123 commented Sep 27, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

deps: upgrade npm to 3.10.8 by zkat · Pull Request #8706 · nodejs/node · GitHub

Uh oh!

Uh oh!

deps: upgrade npm to 3.10.8 - #8706

deps: upgrade npm to 3.10.8#8706zkat wants to merge 2 commits intonodejs:masternodejs/node:masterfrom npm:npm-3.10.8npm/node:npm-3.10.8Copy head branch name to clipboard

Conversation

zkat commented Sep 22, 2016

Checklist

Affected core subsystem(s)

Description of change

Notable Changes:

Changelogs

Uh oh!

zkat commented Sep 22, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gibfahn commented Sep 22, 2016

Uh oh!

zkat commented Sep 22, 2016

Uh oh!

Fishrock123 commented Sep 22, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Fishrock123 commented Sep 22, 2016

Uh oh!

zkat commented Sep 22, 2016

Uh oh!

Fishrock123 commented Sep 22, 2016

Uh oh!

Fishrock123 commented Sep 27, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

deps: upgrade npm to 3.10.8#8706
zkat wants to merge 2 commits into
nodejs:masterfrom
npm:npm-3.10.8

zkat commented Sep 22, 2016 •
edited
Loading

Fishrock123 commented Sep 22, 2016 •
edited
Loading