FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: remove FIXME pummel/test-tls-securepair-client by ALJCepeda · Pull Request #8757 · nodejs/node · GitHub

/ node Public

test: remove FIXME pummel/test-tls-securepair-client - #8757

Closed
ALJCepeda wants to merge 1 commit into
nodejs:masterfrom
ALJCepeda:4640-9
ConversationCommits (1)ChecksFiles changed
Closed

test: remove FIXME pummel/test-tls-securepair-client#8757
ALJCepeda wants to merge 1 commit into
nodejs:masterfrom
ALJCepeda:4640-9

Conversation

ALJCepeda commented Sep 24, 2016 •
edited
Loading

Copy link
Copy Markdown
Contributor
Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

Reverts: 85827bd
Refs: #4640
Using common.PORT no longer causes other tests to fail

Currently running make -j4 test returns errors for parallel/test-internal-modules and parallel/test-repl but that seems to be unrelated to this pull request.
It seems that there's something unusual going on with the VM I use to build

test: remove FIXME pummel/test-tls-securepair-client
c6ed3e6 
Reverts: 85827bd
Refs: nodejs#4640
Using `common.PORT` no longer causes other tests to fail
nodejs-github-bot added the test Issues and PRs related to the tests. label Sep 24, 2016
mscdex added the tls Issues and PRs related to the tls subsystem. label Sep 24, 2016

lpinca commented Sep 25, 2016

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/4274/

lpinca commented Sep 25, 2016

Copy link
Copy Markdown
Member

LGTM if CI is green.

ALJCepeda commented Sep 26, 2016 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

It seems that most of the builds are failing https://ci.nodejs.org/job/node-test-pull-request/ maybe infrastructure issues still?

imyller commented Sep 26, 2016

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/4296/

Trott commented Sep 27, 2016

Copy link
Copy Markdown
Member

Note that pummel tests are not run in CI, so the CI is basically only valuable for the linting in this case.

Test seems to work as expected with the change, so LGTM.

/cc @bnoordhuis

imyller approved these changes Oct 2, 2016
View reviewed changes

imyller left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM
Test works as expected

jasnell commented Oct 6, 2016

Copy link
Copy Markdown
Member

LGTM

jasnell self-assigned this Oct 6, 2016
jasnell pushed a commit that referenced this pull request Oct 6, 2016
test: remove FIXME pummel/test-tls-securepair-client
647e8e5 
Reverts: 85827bd
Using `common.PORT` no longer causes other tests to fail

Refs: #4640
PR-URL: #8757
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

jasnell commented Oct 6, 2016

Copy link
Copy Markdown
Member

Landed in 647e8e5

jasnell closed this Oct 6, 2016
jasnell pushed a commit that referenced this pull request Oct 10, 2016
test: remove FIXME pummel/test-tls-securepair-client
13b4687 
Reverts: 85827bd
Using `common.PORT` no longer causes other tests to fail

Refs: #4640
PR-URL: #8757
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Fishrock123 pushed a commit that referenced this pull request Oct 11, 2016
test: remove FIXME pummel/test-tls-securepair-client
b579fca 
Reverts: 85827bd
Using `common.PORT` no longer causes other tests to fail

Refs: #4640
PR-URL: #8757
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 22, 2016
test: remove FIXME pummel/test-tls-securepair-client
a2621a2 
Reverts: 85827bd
Using `common.PORT` no longer causes other tests to fail

Refs: #4640
PR-URL: #8757
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins mentioned this pull request Nov 22, 2016
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
+1 more reviewer
imyller imyller approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

jasnell

Labels

test Issues and PRs related to the tests. tls Issues and PRs related to the tls subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL