FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

addin test for _stream.writable finished state by italoacasas · Pull Request #8791 · nodejs/node · GitHub

/ node Public

addin test for _stream.writable finished state - #8791

Closed
italoacasas wants to merge 1 commit into
nodejs:masterfrom
italoacasas:test/stream-writable-finished-state
ConversationCommits (1)ChecksFiles changed
Closed

addin test for _stream.writable finished state#8791
italoacasas wants to merge 1 commit into
nodejs:masterfrom
italoacasas:test/stream-writable-finished-state

Conversation

italoacasas commented Sep 26, 2016

Copy link
Copy Markdown
Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change
  • Adding tests for stream._writableState.finished

Issue related: #8686

nodejs-github-bot added the test Issues and PRs related to the tests. label Sep 26, 2016
mscdex added the stream Issues and PRs related to the stream subsystem. label Sep 26, 2016
mcollina self-assigned this Sep 26, 2016
jasnell reviewed Sep 27, 2016
View reviewed changes
Comment thread test/parallel/test-stream-writable-finished-state.js Outdated

jasnell Sep 27, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The callback here should be wrapped in a common.mustCall() in order to validate that it really does get called.

mcollina requested changes Sep 27, 2016
View reviewed changes
Comment thread test/parallel/test-stream-writable-finished-state.js Outdated

mcollina Sep 27, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Can you please add an assert also here that finished is false?

mcollina commented Sep 27, 2016

Copy link
Copy Markdown
Member

Good job! cc @nodejs/streams

mcollina commented Sep 29, 2016 •
edited
Loading

Copy link
Copy Markdown
Member

Can you please update the commit message to follow our standards?

jasnell commented Sep 30, 2016

Copy link
Copy Markdown
Member

The commit style guidelines are detailed here: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#step-3-commit :-)

rvagg force-pushed the master branch 2 times, most recently from c133999 to 83c7a88 Compare October 18, 2016 17:02

italoacasas commented Oct 25, 2016

Copy link
Copy Markdown
Author

@mcollina ping

mcollina approved these changes Oct 26, 2016
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

mcollina commented Oct 26, 2016

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/4678/

mcollina commented Oct 26, 2016

Copy link
Copy Markdown
Member

Failures unrelated. This is good to go, I'm planning on merging tomorrow or Friday, if no one else has objections.

cjihrig reviewed Oct 26, 2016
View reviewed changes
Comment thread test/parallel/test-stream-writable-finished-state.js Outdated

cjihrig Oct 26, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Could you capitalize and punctuate the comment please.

mcollina commented Oct 28, 2016 •
edited
Loading

Copy link
Copy Markdown
Member

Merged in f12338d

mcollina closed this Oct 28, 2016
mcollina pushed a commit that referenced this pull request Oct 28, 2016
test: writable stream finished state
f12338d 
Add a test for _writableState.finished.

PR-URL: #8791
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Related: #8686
evanlucas pushed a commit that referenced this pull request Nov 3, 2016
test: writable stream finished state
d6f688a 
Add a test for _writableState.finished.

PR-URL: #8791
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Related: #8686
evanlucas mentioned this pull request Nov 3, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Nov 17, 2016
test: writable stream finished state
a2eedb1 
Add a test for _writableState.finished.

PR-URL: #8791
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Related: #8686
MylesBorins pushed a commit that referenced this pull request Nov 17, 2016
test: writable stream finished state
80a26c7 
Add a test for _writableState.finished.

PR-URL: #8791
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Related: #8686
MylesBorins pushed a commit that referenced this pull request Nov 19, 2016
test: writable stream finished state
f64d93f 
Add a test for _writableState.finished.

PR-URL: #8791
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Related: #8686
This was referenced Nov 22, 2016
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell left review comments
mcollina mcollina approved these changes
cjihrig cjihrig approved these changes

Assignees

mcollina

Labels

stream Issues and PRs related to the stream subsystem. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL