FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

win,msi: mark INSTALLDIR property as secure by joaocgreis · Pull Request #8795 · nodejs/node · GitHub

/ node Public

win,msi: mark INSTALLDIR property as secure - #8795

Closed
joaocgreis wants to merge 1 commit into
nodejs:masterfrom
JaneaSystems:joaocgreis-G9Q-INSTALLDIR-secure
ConversationCommits (1)ChecksFiles changed
Closed

win,msi: mark INSTALLDIR property as secure#8795
joaocgreis wants to merge 1 commit into
nodejs:masterfrom
JaneaSystems:joaocgreis-G9Q-INSTALLDIR-secure

Conversation

joaocgreis commented Sep 26, 2016

Copy link
Copy Markdown
Member
Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

Windows, MSI.

Description of change

When installing with Always install with elevated privileges policy set on Windows, MSIExec will spawn an installation process with elevated privileges, but will only be able to pass secure properties to it. Without this change, INSTALLDIR could not be passed and would revert to the default, effectively ignoring any change in the installation directory made by the user.

This marks INSTALLDIR as secure, allowing it to be passed to the server MSIExec process during installation.

Tested on Windows 7 with the policy set, with the MSI and INSTALLDIR in two different non-C hard drives (showing that other properties get their values corretly). Also tested upgrade from released Node 6.4 to this on Windows 10.

Fixes: #6057

cc @nodejs/platform-windows

win,msi: mark INSTALLDIR property as secure
c01a163 
Allows INSTALLDIR to be passed to the server MSIExec process during
installation.

Fixes: nodejs#6057
joaocgreis added windows Issues and PRs related to the Windows platform. install Issues and PRs related to the installers. lts-watch-v4.x labels Sep 26, 2016
nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Sep 26, 2016

joaocgreis commented Sep 26, 2016

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/view/All/job/node-test-pull-request/4292/

benjamingr commented Sep 26, 2016

Copy link
Copy Markdown
Member

LGTM - this change sounds reasonable. For those who want a reference http://wixtoolset.org/documentation/manual/v3/xsd/wix/property.html

jasnell approved these changes Sep 27, 2016
View reviewed changes

jasnell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

jasongin commented Sep 27, 2016

Copy link
Copy Markdown
Member

jasnell commented Oct 7, 2016

Copy link
Copy Markdown
Member

@nodejs/build ... does this LGTY?

joaocgreis commented Oct 7, 2016

Copy link
Copy Markdown
Member Author

@jasnell sorry, I left this one too long. I take the reviews above as enough to move forward here, I'll land this early next week if there are no objections (or feel free to if you want to land). Thanks for the ping!

joaocgreis commented Oct 10, 2016

Copy link
Copy Markdown
Member Author

Landed in 4896f0f

joaocgreis closed this Oct 10, 2016
joaocgreis added a commit that referenced this pull request Oct 10, 2016
win,msi: mark INSTALLDIR property as secure
4896f0f 
Allows INSTALLDIR to be passed to the server MSIExec process during
installation.

PR-URL: #8795
Fixes: #6057
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell pushed a commit that referenced this pull request Oct 10, 2016
win,msi: mark INSTALLDIR property as secure
58550fd 
Allows INSTALLDIR to be passed to the server MSIExec process during
installation.

PR-URL: #8795
Fixes: #6057
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Fishrock123 pushed a commit that referenced this pull request Oct 11, 2016
win,msi: mark INSTALLDIR property as secure
b83f51a 
Allows INSTALLDIR to be passed to the server MSIExec process during
installation.

PR-URL: #8795
Fixes: #6057
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 18, 2016
win,msi: mark INSTALLDIR property as secure
bdb6cf9 
Allows INSTALLDIR to be passed to the server MSIExec process during
installation.

PR-URL: #8795
Fixes: #6057
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins mentioned this pull request Nov 22, 2016
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes

Assignees

No one assigned

Labels

install Issues and PRs related to the installers. tools Issues and PRs related to the tools directory. windows Issues and PRs related to the Windows platform.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL