FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

adding test for _stream_writable.js needDrain state by italoacasas · Pull Request #8799 · nodejs/node · GitHub

/ node Public

adding test for _stream_writable.js needDrain state - #8799

Closed
italoacasas wants to merge 1 commit into
nodejs:masterfrom
italoacasas:test/needDrain_state
ConversationCommits (1)ChecksFiles changed
Closed

adding test for _stream_writable.js needDrain state#8799
italoacasas wants to merge 1 commit into
nodejs:masterfrom
italoacasas:test/needDrain_state

Conversation

italoacasas commented Sep 27, 2016

Copy link
Copy Markdown
Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
  • test
Description of change
  • Adding tests for stream._writableState.needDrain

Issue related: #8686

nodejs-github-bot added the test Issues and PRs related to the tests. label Sep 27, 2016
lpinca added the stream Issues and PRs related to the stream subsystem. label Sep 27, 2016
jasnell reviewed Sep 27, 2016
View reviewed changes
Comment thread test/parallel/test-stream-writable-needdrain-state.js Outdated

jasnell Sep 27, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

this callback should be wrapped in a common.mustCall() to ensure that it's actually called.

addaleax approved these changes Sep 30, 2016
View reviewed changes

addaleax left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

jasnell approved these changes Sep 30, 2016
View reviewed changes

jasnell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

jasnell commented Sep 30, 2016

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/4334/

rvagg force-pushed the master branch 2 times, most recently from c133999 to 83c7a88 Compare October 18, 2016 17:02

italoacasas commented Oct 25, 2016

Copy link
Copy Markdown
Author

@mcollina ping

mcollina approved these changes Oct 26, 2016
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

mcollina commented Oct 26, 2016

Copy link
Copy Markdown
Member

Ci: https://ci.nodejs.org/job/node-test-pull-request/4681/

mcollina commented Oct 26, 2016

Copy link
Copy Markdown
Member

Failures unrelated. This is good to go, I'm planning on merging tomorrow or Friday, if no one else has objections.

mcollina commented Oct 28, 2016 •
edited
Loading

Copy link
Copy Markdown
Member

Merged in 9ed7261

mcollina closed this Oct 28, 2016
mcollina pushed a commit that referenced this pull request Oct 28, 2016
test: writable stream needDrain state
9ed7261 
Add a test for _writableState.needDrain.

PR-URL: #8799
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Related: #8686
evanlucas pushed a commit that referenced this pull request Nov 3, 2016
test: writable stream needDrain state
c9b67c6 
Add a test for _writableState.needDrain.

PR-URL: #8799
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Related: #8686
evanlucas mentioned this pull request Nov 3, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Nov 18, 2016
test: writable stream needDrain state
4b50419 
Add a test for _writableState.needDrain.

PR-URL: #8799
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Related: #8686
MylesBorins pushed a commit that referenced this pull request Nov 18, 2016
test: writable stream needDrain state
40ef239 
Add a test for _writableState.needDrain.

PR-URL: #8799
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Related: #8686
MylesBorins pushed a commit that referenced this pull request Nov 19, 2016
test: writable stream needDrain state
1fee6c1 
Add a test for _writableState.needDrain.

PR-URL: #8799
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Related: #8686
This was referenced Nov 22, 2016
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcollina mcollina approved these changes
jasnell jasnell approved these changes
addaleax addaleax approved these changes
cjihrig cjihrig approved these changes

Assignees

No one assigned

Labels

stream Issues and PRs related to the stream subsystem. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL