tools: fix release script on macOS 10.12 - #8824
Conversation
Sorry, something went wrong.
|
I'd like to verify that this doesn't break support for subkeys... as this code has been fragile to that before |
Sorry, something went wrong.
jasnell
left a comment
There was a problem hiding this comment.
Changes LGTM but I agree with @thealphanerd that we'll want to test this a bit more before landing
Sorry, something went wrong.
|
/cc @Fishrock123 and @rvagg any opinion on this? |
Sorry, something went wrong.
|
I think this might be from a new version of git, or perhaps gnupg, I'm noticing now on 10.10 that it comes out saying "using RSA key ..." with "key ID" nowhere to be found! I'd still be more comfortable limiting the text a tiny bit more, perhaps just inserting a grep key there, without the awk? |
Sorry, something went wrong.
|
@rvagg the reason I switched it around was because more of the key is now shown in the newer versions. Here is an example to show what I mean: Before: gpg: Signature made Tue Sep 27 19:06:18 2016 CDT using RSA key ID 4C206CA9 After: gpg: using RSA key B63B535A4C206CA9 So the if [ "${gpgtagkey}" != "${gpgkey}" ]; then would end up failing |
Sorry, something went wrong.
|
@evanlucas what I meant was, inserting a grep for the word "key" as well, probably not really a material change though. @thealphanerd just got caught by this for v6.9.1 so we should get it merged and backported to v7, v6 and v4. |
Sorry, something went wrong.
Previously, we were relying on the output of gpg from git tag -v to verify that the key selected by the releaser is the key that was used to sign the tag. This output can change depending on the version of git being used. Now, we just check that the output of git tag -v contains the key selected. Fixes: nodejs#8822
|
@rvagg ah sorry. Updated. PTAL |
Sorry, something went wrong.
|
lgtm |
Sorry, something went wrong.
Previously, we were relying on the output of gpg from git tag -v to verify that the key selected by the releaser is the key that was used to sign the tag. This output can change depending on the version of git being used. Now, we just check that the output of git tag -v contains the key selected. Fixes: #8822 PR-URL: #8824 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>
Previously, we were relying on the output of gpg from git tag -v to verify that the key selected by the releaser is the key that was used to sign the tag. This output can change depending on the version of git being used. Now, we just check that the output of git tag -v contains the key selected. Fixes: #8822 PR-URL: #8824 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>
Previously, we were relying on the output of gpg from git tag -v to verify that the key selected by the releaser is the key that was used to sign the tag. This output can change depending on the version of git being used. Now, we just check that the output of git tag -v contains the key selected. Fixes: #8822 PR-URL: #8824 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>
Previously, we were relying on the output of gpg from git tag -v to verify that the key selected by the releaser is the key that was used to sign the tag. This output can change depending on the version of git being used. Now, we just check that the output of git tag -v contains the key selected. Fixes: #8822 PR-URL: #8824 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>
Checklist
Affected core subsystem(s)
tools
Description of change
Previously, we were relying on the output of gpg from git tag -v to
verify that the key selected by the releaser is the key that was used
to sign the tag. This output can change depending on the version of git
being used. Now, we just check that the output of git tag -v contains
the key selected.
Fixes: #8822
/cc @nodejs/release