FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

internal: fix TypeError in v8-polyfill by geek · Pull Request #8863 · nodejs/node · GitHub

/ node Public

internal: fix TypeError in v8-polyfill - #8863

Closed
geek wants to merge 1 commit into
nodejs:masterfrom
geek:fix-v8-polyfill
ConversationCommits (1)ChecksFiles changed
Closed

internal: fix TypeError in v8-polyfill#8863
geek wants to merge 1 commit into
nodejs:masterfrom
geek:fix-v8-polyfill

Conversation

geek commented Sep 30, 2016 •
edited
Loading

Copy link
Copy Markdown
Member
Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

v8 profile processor

Description of change

readline() can return a boolean, in which case, line 90 will throw an exception. This change addresses the issue by defaulting to a string in readline() instead of returning false.

nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Sep 30, 2016
mscdex added process Issues and PRs related to the process subsystem. and removed tools Issues and PRs related to the tools directory. labels Sep 30, 2016
jasnell approved these changes Sep 30, 2016
View reviewed changes

jasnell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

jasnell commented Sep 30, 2016

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/4336/

bnoordhuis requested changes Oct 3, 2016
View reviewed changes

bnoordhuis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I'd change the return false in readline() to return '', that way future call sites won't run into the same issue.

If other collaborators think this is fine though, I'm fine with it too.

geek force-pushed the fix-v8-polyfill branch from b5a879b to d3f5d8a Compare October 4, 2016 21:30

geek commented Oct 4, 2016

Copy link
Copy Markdown
Member Author

@bnoordhuis fixed

bnoordhuis commented Oct 5, 2016

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/4391/

geek commented Oct 5, 2016

Copy link
Copy Markdown
Member Author

This was the failure on AIX

https://ci.nodejs.org/job/node-test-commit-aix/1300/

length differs.
expect=2
actual=0
patterns:
pattern = ^hello\ world\ 1$
pattern = ^hello\ world\ 2$
outlines:
not ok 1219 pseudo-tty/test-tty-wrap

I reran the job and it succeeded:

https://ci.nodejs.org/job/node-test-commit-aix/1305/

jasnell pushed a commit that referenced this pull request Oct 6, 2016
lib: fix TypeError in v8-polyfill
47d1588 
PR-URL: #8863
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

jasnell commented Oct 6, 2016

Copy link
Copy Markdown
Member

Landed in 47d1588

jasnell closed this Oct 6, 2016
geek deleted the fix-v8-polyfill branch October 6, 2016 18:21
jasnell pushed a commit that referenced this pull request Oct 6, 2016
lib: fix TypeError in v8-polyfill
aa5664f 
PR-URL: #8863
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

MylesBorins commented Oct 6, 2016

Copy link
Copy Markdown
Contributor

added lts watch as this lands on v4.x let me know if it should not land

jasnell commented Oct 7, 2016

Copy link
Copy Markdown
Member

there's likely no harm in landing it.

Fishrock123 pushed a commit that referenced this pull request Oct 11, 2016
lib: fix TypeError in v8-polyfill
6cd5588 
PR-URL: #8863
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 18, 2016
lib: fix TypeError in v8-polyfill
a3a184d 
PR-URL: #8863
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins mentioned this pull request Nov 22, 2016
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

bnoordhuis bnoordhuis approved these changes
jasnell jasnell approved these changes
cjihrig cjihrig approved these changes
+1 more reviewer
targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

process Issues and PRs related to the process subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL