FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: fix issues reported by Coverity by eugeneo · Pull Request #8870 · nodejs/node · GitHub

/ node Public

test: fix issues reported by Coverity - #8870

Closed
eugeneo wants to merge 0 commit into
nodejs:masterfrom
eugeneo:coverty
ConversationCommits (0)ChecksFiles changed
Closed

test: fix issues reported by Coverity#8870
eugeneo wants to merge 0 commit into
nodejs:masterfrom
eugeneo:coverty

Conversation

eugeneo commented Sep 30, 2016

Copy link
Copy Markdown
Contributor
Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

This is a refactoring of the inspector socket test case.

Description of change

Wrapped the timer into class to ensure it is cleaned up properly.

CC: @ofrobots

nodejs-github-bot added the test Issues and PRs related to the tests. label Sep 30, 2016
eugeneo changed the title test: fix issues reported by Coverty test: fix issues reported by Coverity Sep 30, 2016
eugeneo added c++ Issues and PRs that require attention from people who are familiar with C++. inspector Issues and PRs related to the V8 inspector protocol labels Sep 30, 2016

eugeneo commented Oct 1, 2016

Copy link
Copy Markdown
Contributor Author

Test failures are caused by parallel/test-tick-processor-builtin and parallel/test-tick-processor-unknown and do not seem to caused by this change, that only touches cctest executable.

bnoordhuis requested changes Oct 1, 2016
View reviewed changes
Comment thread test/cctest/test_inspector_socket.cc Outdated

bnoordhuis Oct 1, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

explicit

eugeneo Oct 6, 2016

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Done

Comment thread test/cctest/test_inspector_socket.cc Outdated

bnoordhuis Oct 1, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Style nit: can you either call this SetFlag or set_flag? Ditto for markDone.

eugeneo Oct 6, 2016

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Done (used set_flag and mark_done)

jasnell commented Oct 6, 2016

Copy link
Copy Markdown
Member

LGTM once @bnoordhuis is happy with it.

eugeneo commented Oct 6, 2016

Copy link
Copy Markdown
Contributor Author

Thank you for the review. I uploaded a new version, please take another look.

ofrobots commented Oct 7, 2016

Copy link
Copy Markdown
Contributor

LGTM

eugeneo commented Oct 11, 2016

Copy link
Copy Markdown
Contributor Author

@bnoordhuis I've implemented your suggestions, please take another look.

bnoordhuis approved these changes Oct 12, 2016
View reviewed changes
Comment thread test/cctest/test_inspector_socket.cc Outdated

bnoordhuis Oct 12, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

While you're here, maybe you can remove the extraneous parentheses around condition?

eugeneo pushed a commit that referenced this pull request Oct 13, 2016
test: fix issues reported by Coverity
ec7f3a1 
Wrapped the timer into class to ensure it is cleaned up properly.

PR-URL: #8870
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
eugeneo closed this Oct 13, 2016
eugeneo deleted the coverty branch October 13, 2016 23:32
jasnell pushed a commit that referenced this pull request Oct 14, 2016
test: fix issues reported by Coverity
0ad0e6a 
Wrapped the timer into class to ensure it is cleaned up properly.

PR-URL: #8870
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
MylesBorins pushed a commit that referenced this pull request Nov 11, 2016
test: fix issues reported by Coverity
ae3f31b 
Wrapped the timer into class to ensure it is cleaned up properly.

PR-URL: #8870
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
MylesBorins mentioned this pull request Nov 22, 2016
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

bnoordhuis bnoordhuis approved these changes
+1 more reviewer
ofrobots ofrobots approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. inspector Issues and PRs related to the V8 inspector protocol test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL