FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: refactor test-net-server-max-connections by Trott · Pull Request #8931 · nodejs/node · GitHub

/ node Public

test: refactor test-net-server-max-connections - #8931

Closed
Trott wants to merge 2 commits into
nodejs:masterfrom
Trott:max-conn
ConversationCommits (2)ChecksFiles changed
Closed

test: refactor test-net-server-max-connections#8931
Trott wants to merge 2 commits into
nodejs:masterfrom
Trott:max-conn

Conversation

Trott commented Oct 4, 2016

Copy link
Copy Markdown
Member
Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test net

Description of change

The test timed out on Windows in CI. Made the following changes:

  • reduced total connections from 200 to 20
  • var -> const
  • string concatenation -> templates
  • assert.equal -> assert.strictEqual

/cc @nodejs/testing

Trott added net Issues and PRs related to the net subsystem. test Issues and PRs related to the tests. labels Oct 4, 2016
nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 4, 2016

Trott commented Oct 4, 2016

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/4388/

santigimeno reviewed Oct 5, 2016
View reviewed changes
Comment thread test/parallel/test-net-server-max-connections.js Outdated

santigimeno Oct 5, 2016 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Maybe wrap the callback with common.mustCall(function() {}, N/2) and remove the count variable as it's not being used except for the debug log. Also, I would probably remove the logs from the code.

santigimeno commented Oct 5, 2016

Copy link
Copy Markdown
Member

LGTM with one suggestion.

CI looks green except from one unrelated known flaky test.

Trott added 2 commits October 5, 2016 10:50
test: refactor test-net-server-max-connections
1ffb714 
The test timed out on Windows in CI. Made the following changes:

* reduced total connections from 200 to 20
* var -> const
* string concatenation -> templates
* assert.equal -> assert.strictEqual
squash: nits
d467bbc

Trott commented Oct 5, 2016

Copy link
Copy Markdown
Member Author

CI with changes per nits from santigimeno: https://ci.nodejs.org/job/node-test-pull-request/4398/

Trott commented Oct 5, 2016

Copy link
Copy Markdown
Member Author

Running again: https://ci.nodejs.org/job/node-test-pull-request/4399/

santigimeno approved these changes Oct 6, 2016
View reviewed changes

santigimeno left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

lpinca approved these changes Oct 6, 2016
View reviewed changes

lpinca left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

jasnell approved these changes Oct 6, 2016
View reviewed changes

jasnell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

jasnell commented Oct 6, 2016

Copy link
Copy Markdown
Member

CI failure on windows looks unrelated

jasnell pushed a commit that referenced this pull request Oct 6, 2016
test: refactor test-net-server-max-connections
eff6205 
The test timed out on Windows in CI. Made the following changes:

* reduced total connections from 200 to 20
* var -> const
* string concatenation -> templates
* assert.equal -> assert.strictEqual

PR-URL: #8931
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

jasnell commented Oct 6, 2016

Copy link
Copy Markdown
Member

Landed in eff6205

jasnell closed this Oct 6, 2016
jasnell pushed a commit that referenced this pull request Oct 10, 2016
test: refactor test-net-server-max-connections
1122e87 
The test timed out on Windows in CI. Made the following changes:

* reduced total connections from 200 to 20
* var -> const
* string concatenation -> templates
* assert.equal -> assert.strictEqual

PR-URL: #8931
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Fishrock123 pushed a commit that referenced this pull request Oct 11, 2016
test: refactor test-net-server-max-connections
df0211d 
The test timed out on Windows in CI. Made the following changes:

* reduced total connections from 200 to 20
* var -> const
* string concatenation -> templates
* assert.equal -> assert.strictEqual

PR-URL: #8931
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 18, 2016
test: refactor test-net-server-max-connections
7904066 
The test timed out on Windows in CI. Made the following changes:

* reduced total connections from 200 to 20
* var -> const
* string concatenation -> templates
* assert.equal -> assert.strictEqual

PR-URL: #8931
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins mentioned this pull request Nov 22, 2016
Merged
Trott deleted the max-conn branch January 13, 2022 22:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
santigimeno santigimeno approved these changes
lpinca lpinca approved these changes

Assignees

No one assigned

Labels

net Issues and PRs related to the net subsystem. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL