| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
There was a problem hiding this comment.
proposal
Sorry, something went wrong.
There was a problem hiding this comment.
Is there a whitespace at the end of the line?
Sorry, something went wrong.
There was a problem hiding this comment.
SGTM!
Sorry, something went wrong.
There was a problem hiding this comment.
LGTM modulo what @thefourtheye pointed out.
Sorry, something went wrong.
There was a problem hiding this comment.
Tiny nit but isn't it spelled 'commit access', no dash?
Sorry, something went wrong.
|
LGTM subject to comments identified by others. |
Sorry, something went wrong.
There was a problem hiding this comment.
LGTM. Again, with the nits addressed.
Sorry, something went wrong.
There was a problem hiding this comment.
Seems a bit tight for ensuring consensus imo
Sorry, something went wrong.
There was a problem hiding this comment.
Seems a bit tight for ensuring consensus imo
What would seem a better duration in your opinion? I chose 72 hours because that seemed like a duration for an issue on the tracker that was more likely to actually map to real consensus than a conversation at a meeting attended by maybe 10 of the CTC's 18 members. Arguably, that's not a high bar, but it's what we have now, so that's what I used as an approximate metric. Totally open to other ideas. What did you have in mind?
Sorry, something went wrong.
|
This LGTM with nits addressed. |
Sorry, something went wrong.
As the CTC grows and has representation from more time zones, we need to embrace asynchronous decision making and rely less on the actual meeting. This change is a proposal for that which, ironically, probably has to be approved at a meeting.
|
Nits addressed, rebased, force pushed. |
Sorry, something went wrong.
|
Does this still need to be on the ctc-agenda? |
Sorry, something went wrong.
Yes. |
Sorry, something went wrong.
|
It would be great if CTC folks could read the new paragraph and the bullet points and weighed in before the meeting. I'd be happy to not have to bring this to the meeting. CTC folks who have not offered an opinion yet: |
Sorry, something went wrong.
|
ctc-review might be a good idea, however it's really at the discretion of the meeting chair whether something goes on the agenda or not and some things can be left off as required. This lgtm for now. I'm hesitant with the 72-hours two-only requirement for passing major things, but we can only see how it goes and adjust if enough of us are unhappy with the process. My main concern is simply with the workload of GitHub notifications and I'm constantly behind these days. I'll just have to make sure I tune in to nodejs/ctc tagged items! |
Sorry, something went wrong.
|
lgtm. I'd be +1 to a ctc-review label. I think it would make it a lot easier to see what issues need attention. |
Sorry, something went wrong.
|
+1 in general, but with splitting a «CTC should take a look at this» with «this escalated to voting». The moment when it has been escalated to voting should be clearly visible. That is probably a separate thing from ctc-review (review needed by the CTC) and ctc-agenda (consensus-seeking). ctc-vote, perhaps? Currently ctc-review and ctc-agenda labels are present or proposed. Could we codify both of those? |
Sorry, something went wrong.
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
|
I want to echo @rvagg's hesitation on the 72 hour + 2 ctc minimum for moving things forward. Obviously this will be a case by case basis... but if something is controversial I do thing we need to have a bit of a wider consensus on it. I think a hard rule here may miss the point, but I feel we may need more time + opinions on it. I'm +1 on everything but that nit. |
Sorry, something went wrong.
|
LGTM w/ the same hesitation as @thealphanerd and @rvagg. |
Sorry, something went wrong.
That may be true in practice, but it is in contradiction of our GOVERNANCE.md doc which says of the CTC agenda:
|
Sorry, something went wrong.
|
I've created the ctc-review label. Documenting it in GOVERNANCE.md will be in a subsequent pull request. |
Sorry, something went wrong.
|
I count at least 11 (and possibly as many as 14) approvals from current CTC members. The approvals as I see it come from: addaleax There are also maybe-approvals-I'm-not-sure from: chalker So I think this can land. I'll create a ctc-agenda issue for discussion of how this is working or not working. We can probably leave that on the meeting agenda for two or three weeks. If nothing else, people can give feedback on whether 72 hours is working or not. |
Sorry, something went wrong.
As the CTC grows and has representation from more time zones, we need to embrace asynchronous decision making and rely less on the actual meeting. This change is a proposal for that which, ironically, probably has to be approved at a meeting. PR-URL: nodejs#8945 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Julien Gilli <jgilli@nodejs.org> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>
|
Landed in b899140. Thanks, everyone. |
Sorry, something went wrong.
As the CTC grows and has representation from more time zones, we need to embrace asynchronous decision making and rely less on the actual meeting. This change is a proposal for that which, ironically, probably has to be approved at a meeting. PR-URL: #8945 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Julien Gilli <jgilli@nodejs.org> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>
As the CTC grows and has representation from more time zones, we need to embrace asynchronous decision making and rely less on the actual meeting. This change is a proposal for that which, ironically, probably has to be approved at a meeting. PR-URL: #8945 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Julien Gilli <jgilli@nodejs.org> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>
As the CTC grows and has representation from more time zones, we need to embrace asynchronous decision making and rely less on the actual meeting. This change is a proposal for that which, ironically, probably has to be approved at a meeting. PR-URL: #8945 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Julien Gilli <jgilli@nodejs.org> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>
| Back | FazBrowse Home | New Git URL |
Checklist
Affected core subsystem(s)
Description of change
As the CTC grows and has representation from more time zones, we need to
embrace asynchronous decision making and rely less on the actual
meeting. This change is a proposal for that which, ironically, probably
has to be approved at a meeting.
/cc @nodejs/ctc