crypto: use SSL_get_SSL_CTX. - #8995
Conversation
Sorry, something went wrong.
SSL_get_SSL_CTX returns the SSL_CTX for an SSL. Previously the code accessed |ssl->ctx| directly, but that's no longer possible with OpenSSL 1.1.0. SSL_get_SSL_CTX exists all the way back to (at least) OpenSSL 0.9.8 and so this change should be fully compatible.
|
/cc @nodejs/crypto |
Sorry, something went wrong.
bnoordhuis
left a comment
There was a problem hiding this comment.
LGTM. CI seems to be unreachable at the moment.
Sorry, something went wrong.
indutny
left a comment
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
|
CI is running on https://ci.nodejs.org/job/node-test-pull-request/4485/. |
Sorry, something went wrong.
shigeki
left a comment
There was a problem hiding this comment.
CI icons show they are still in progress on Linux platforms but I confirmed all tests were finished and green. FreeBSD failures were due to npm install errors so they are nothing to do with this. LTGM
Sorry, something went wrong.
SSL_get_SSL_CTX returns the SSL_CTX for an SSL. Previously the code accessed |ssl->ctx| directly, but that's no longer possible with OpenSSL 1.1.0. SSL_get_SSL_CTX exists all the way back to (at least) OpenSSL 0.9.8 and so this change should be fully compatible. PR-URL: #8995 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>
SSL_get_SSL_CTX returns the SSL_CTX for an SSL. Previously the code accessed |ssl->ctx| directly, but that's no longer possible with OpenSSL 1.1.0. SSL_get_SSL_CTX exists all the way back to (at least) OpenSSL 0.9.8 and so this change should be fully compatible. PR-URL: #8995 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>
|
@shigeki / @jasnell should this be backported? It lands cleanly on v6 but not on v4. My gut is to say just land it cleanly on v6 but avoid v4... just in case of future security changes we can limit the delta in the implementations. Thoughts? |
Sorry, something went wrong.
|
@thealphanerd this isn't necessary for v4, I'd go with v6, though. |
Sorry, something went wrong.
SSL_get_SSL_CTX returns the SSL_CTX for an SSL. Previously the code accessed |ssl->ctx| directly, but that's no longer possible with OpenSSL 1.1.0. SSL_get_SSL_CTX exists all the way back to (at least) OpenSSL 0.9.8 and so this change should be fully compatible. PR-URL: #8995 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>
Checklist
Affected core subsystem(s)
crypto
Description of change
SSL_get_SSL_CTX returns the SSL_CTX for an SSL. Previously the code
accessed ssl->ctx directly, but that's no longer possible with OpenSSL
1.1.0.
SSL_get_SSL_CTX exists all the way back to (at least) OpenSSL 0.9.8 and
so this change should be fully compatible.