FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

change for a deprecated method: SetNamedPropertyHandler() to SetHandler() by AnnaMag · Pull Request #9062 · nodejs/node · GitHub

/ node Public

change for a deprecated method: SetNamedPropertyHandler() to SetHandler() - #9062

Closed
AnnaMag wants to merge 1 commit into
nodejs:masterfrom
AnnaMag:sethandler
ConversationCommits (1)ChecksFiles changed
Closed

change for a deprecated method: SetNamedPropertyHandler() to SetHandler()#9062
AnnaMag wants to merge 1 commit into
nodejs:masterfrom
AnnaMag:sethandler

Conversation

AnnaMag commented Oct 12, 2016 •
edited
Loading

Copy link
Copy Markdown
Member
Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Description of change

SetNamedPropertyHandler() method replaced with SetHandler() in process_env_template

PropertyHandlerFlags::kOnlyInterceptStrings flag maintains previous behavior: only Strings as properties are intercepted. In theory, it is now possible to extend the functionality for intercepting properties using Symbols (in practice a fix is required: I will create an issue when this pull request is merged).

nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Oct 12, 2016
cjihrig reviewed Oct 12, 2016
View reviewed changes
Comment thread test/parallel/test-v8-interceptStrings-not-Symbols.js Outdated

cjihrig Oct 12, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Can you remove the references to specific lines. They will almost certainly get stale quickly.

cjihrig reviewed Oct 12, 2016
View reviewed changes
Comment thread test/parallel/test-v8-interceptStrings-not-Symbols.js Outdated

cjihrig Oct 12, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Can you capitalize and punctuate the the comments. Also, add a space after // in some of the comments below.

cjihrig reviewed Oct 12, 2016
View reviewed changes
Comment thread test/parallel/test-v8-interceptStrings-not-Symbols.js Outdated

cjihrig Oct 12, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

These assertions are already covered by the previous two assertions.

mscdex added the process Issues and PRs related to the process subsystem. label Oct 12, 2016
bnoordhuis approved these changes Oct 13, 2016
View reviewed changes

bnoordhuis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM with a suggestion.

Comment thread test/parallel/test-v8-interceptStrings-not-Symbols.js Outdated

bnoordhuis Oct 13, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

const?

bnoordhuis commented Oct 13, 2016

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/4500/

jasnell approved these changes Oct 13, 2016
View reviewed changes

jasnell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

fhinkel commented Oct 13, 2016

Copy link
Copy Markdown
Contributor

Can you squash the commits into one?

For the comments in the tests, right now some of them document what you did in the refactoring. For somebody reading the tests in a few month, it's probably not so important that there was a refactoring, but more what the test is testing. Maybe you can rewrite the comments not so much focusing on your change, but rather what you want to test (The test is valid with or without the refactoring).

cjihrig approved these changes Oct 13, 2016
View reviewed changes

cjihrig left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, though I agree with @fhinkel about the comments. You also don't need to include your handle in the comment.

AnnaMag commented Oct 14, 2016

Copy link
Copy Markdown
Member Author

Done.

jasnell commented Oct 14, 2016

Copy link
Copy Markdown
Member

@AnnaMag ... can you please update the commit log to match the contribution guidelines here: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#step-3-commit

AnnaMag force-pushed the sethandler branch 4 times, most recently from 3bc11a4 to 8b404de Compare October 14, 2016 19:27
rvagg force-pushed the master branch 2 times, most recently from c133999 to 83c7a88 Compare October 18, 2016 17:02

jasnell commented Oct 19, 2016

Copy link
Copy Markdown
Member

New CI: https://ci.nodejs.org/job/node-test-pull-request/4579/

AnnaMag commented Oct 26, 2016

Copy link
Copy Markdown
Member Author

@jasnell, the failures are timeouts, which in my understanding are not patch related. Am I right or missing sth?

jasnell commented Oct 26, 2016

Copy link
Copy Markdown
Member

Yep, they appear to be unrelated

fhinkel commented Oct 27, 2016

Copy link
Copy Markdown
Contributor

Can you address Ben's comment? Then we can merge this.

src: replace SetNamedPropertyHandler() with SetHandler()
9c397a0 
The changes introdcued here replace the deprecated
v8 method SetNamedPropertyHandler() to SetHandler()
in node.cc.
Prior to refactoring, the method defined callbacks
when accessing object properties defined by Strings
and not Symbols.
test/parallel/test-v8-interceptStrings-not-Symbols.js
demonstrates that this behaviour remained unchanged
after refactoring.

AnnaMag commented Oct 27, 2016

Copy link
Copy Markdown
Member Author

Done:)

fhinkel commented Nov 1, 2016

Copy link
Copy Markdown
Contributor

LGTM

fhinkel commented Nov 1, 2016

Copy link
Copy Markdown
Contributor

Landed in ab19412

fhinkel closed this Nov 1, 2016
fhinkel pushed a commit that referenced this pull request Nov 1, 2016
src: replace SetNamedPropertyHandler()
ab19412 
The changes introdcued here replace the deprecated
v8 method SetNamedPropertyHandler() to SetHandler()
in node.cc.
Prior to refactoring, the method defined callbacks
when accessing object properties defined by Strings
and not Symbols.
test/parallel/test-v8-interceptStrings-not-Symbols.js
demonstrates that this behaviour remained unchanged
after refactoring.

PR-URL: #9062
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
evanlucas pushed a commit that referenced this pull request Nov 3, 2016
src: replace SetNamedPropertyHandler()
0c236d1 
The changes introdcued here replace the deprecated
v8 method SetNamedPropertyHandler() to SetHandler()
in node.cc.
Prior to refactoring, the method defined callbacks
when accessing object properties defined by Strings
and not Symbols.
test/parallel/test-v8-interceptStrings-not-Symbols.js
demonstrates that this behaviour remained unchanged
after refactoring.

PR-URL: #9062
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
evanlucas mentioned this pull request Nov 3, 2016
Merged

MylesBorins commented Nov 22, 2016

Copy link
Copy Markdown
Contributor

should this be backported?

fhinkel commented Nov 22, 2016

Copy link
Copy Markdown
Contributor

@thealphanerd Live quoting you: "If it lands cleanly, yes please". Thanks.

MylesBorins pushed a commit that referenced this pull request Nov 26, 2016
src: replace SetNamedPropertyHandler()
8a91616 
The changes introdcued here replace the deprecated
v8 method SetNamedPropertyHandler() to SetHandler()
in node.cc.
Prior to refactoring, the method defined callbacks
when accessing object properties defined by Strings
and not Symbols.
test/parallel/test-v8-interceptStrings-not-Symbols.js
demonstrates that this behaviour remained unchanged
after refactoring.

PR-URL: #9062
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>

MylesBorins commented Nov 26, 2016

Copy link
Copy Markdown
Contributor

@fhinkel landed cleanly on v6 but not v4, please feel free to manually backport

MylesBorins mentioned this pull request Dec 1, 2016
Merged
AnnaMag deleted the sethandler branch January 25, 2017 22:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

bnoordhuis bnoordhuis approved these changes
jasnell jasnell approved these changes
cjihrig cjihrig approved these changes

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. process Issues and PRs related to the process subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL