Benchmark fixes - #9064
Conversation
Sorry, something went wrong.
When a benchmark did not contain any parameters the csv configuration filed would be "". In R this is by default parsed as NA, causing NA in the printout too. Fixes: #9061
This changes the execution order from "iter, file, binary" to "file, iter, binary". This means the csv no longer has to buffered completely. This also has the added effect that stopping compare.js early or interfering with performance only affects a single benchmark, instead of all of them. Refs: #8659
Using new syntax such as `...args` means that the benchmark suite can't be used with older node versions. This changes the `...args` syntax to a good old `Array.prototype.slice`. Refs: #8932 (comment)
|
Not overly keen on this. But technically LGTM |
Sorry, something went wrong.
|
@jasnell Which part did you have reservations about? I can confirm the csv parsing fix works. |
Sorry, something went wrong.
|
The changes to v8ForceOptimization. It's no biggie tho. |
Sorry, something went wrong.
|
@jasnell: @trevnorris touched a bit on it in #8637 (comment).
|
Sorry, something went wrong.
|
LGTM |
Sorry, something went wrong.
This changes the execution order from "iter, file, binary" to "file, iter, binary". This means the csv no longer has to buffered completely. This also has the added effect that stopping compare.js early or interfering with performance only affects a single benchmark, instead of all of them. Refs: #8659 PR-URL: #9064 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
Using new syntax such as `...args` means that the benchmark suite can't be used with older node versions. This changes the `...args` syntax to a good old `Array.prototype.slice`. Refs: #8932 (comment) PR-URL: #9064 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
Sorry, something went wrong.
This changes the execution order from "iter, file, binary" to "file, iter, binary". This means the csv no longer has to buffered completely. This also has the added effect that stopping compare.js early or interfering with performance only affects a single benchmark, instead of all of them. Refs: #8659 PR-URL: #9064 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
Using new syntax such as `...args` means that the benchmark suite can't be used with older node versions. This changes the `...args` syntax to a good old `Array.prototype.slice`. Refs: #8932 (comment) PR-URL: #9064 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
|
@jasnell thanks for merging this, kinda forgot about it :) |
Sorry, something went wrong.
Checklist
Affected core subsystem(s)
benchmark
Description of change
Some minor benchmark fixes. I can create 3 separate pull requests if that makes the review process easier.
benchmark: fixes csv parsing given no parameters
When a benchmark did not contain any parameters the csv configuration
filed would be "". In R this is by default parsed as NA, causing NA in
the printout too.
Fixes: #9061
benchmark: change the execution order
This changes the execution order from "iter, file, binary" to "file,
iter, binary". This means the csv no longer has to buffered completely.
This also has the added effect that stopping compare.js early or
interfering with performance only affects a single benchmark, instead of
all of them.
Refs: #8659
benchmark: use node v4 syntax in common.js
Using new syntax such as ...args means that the benchmark suite can't
be used with older node versions. This changes the ...args syntax to a
good old Array.prototype.slice.
Refs: #8932 (comment)