test: use npm sandbox in test-npm-install - #9079
Closed
joaocgreis wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
npm should run in a sandbox to avoid unwanted interactions. Without this change, npm would read the userconfig file $HOME/.npmrc which may contain configs that break this test. Fixes: nodejs#9074
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
Fishrock123
approved these changes
Oct 13, 2016
Fishrock123
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
seems fine to me
Sorry, something went wrong.
jbergstroem
approved these changes
Oct 13, 2016
jbergstroem
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
santigimeno
approved these changes
Oct 13, 2016
santigimeno
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
LGTM |
Sorry, something went wrong.
1 similar comment
Copy link
Copy Markdown
Member
|
LGTM |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
LGTM if CI is clean |
Sorry, something went wrong.
cjihrig
approved these changes
Oct 13, 2016
jasnell
pushed a commit
that referenced
this pull request
Oct 17, 2016
npm should run in a sandbox to avoid unwanted interactions. Without this change, npm would read the userconfig file $HOME/.npmrc which may contain configs that break this test. Fixes: #9074 PR-URL: #9079 Reviewed-By: Jeremiah Senkpiel <Fishrock123@rocketmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 11, 2016
npm should run in a sandbox to avoid unwanted interactions. Without this change, npm would read the userconfig file $HOME/.npmrc which may contain configs that break this test. Fixes: #9074 PR-URL: #9079 Reviewed-By: Jeremiah Senkpiel <Fishrock123@rocketmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 11, 2016
npm should run in a sandbox to avoid unwanted interactions. Without this change, npm would read the userconfig file $HOME/.npmrc which may contain configs that break this test. Fixes: #9074 PR-URL: #9079 Reviewed-By: Jeremiah Senkpiel <Fishrock123@rocketmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This was referenced Nov 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
test
Description of change
npm should run in a sandbox to avoid unwanted interactions. Without this change, npm would read the userconfig file $HOME/.npmrc which may contain configs that break this test.
Not completely sure if we should set the HOME variable as I decided to do here, or track down all the variables that it influences with npm config ls -l and set them all individually. This seems more future-proof, and since it's just to run npm it should be ok.
Taken inspiration from https://github.com/gibfahn/node/blob/a3c1505cd9fd5e26aebdbb2269515f9d3deb11db/tools/test-npm.sh#L44-L48 (ongoing PR #7867) with the HOME var change that may be a good idea there as well, cc @gibfahn .
Fixes: #9074 - test run: https://ci.nodejs.org/job/node-test-commit-freebsd/4799/
cc @nodejs/testing @thealphanerd @Trott