FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

util: use template literals by a0viedo · Pull Request #9120 · nodejs/node · GitHub

/ node Public

util: use template literals - #9120

Closed
a0viedo wants to merge 1 commit into
nodejs:masterfrom
a0viedo:template-literals-util
ConversationCommits (1)ChecksFiles changed
Closed

util: use template literals#9120
a0viedo wants to merge 1 commit into
nodejs:masterfrom
a0viedo:template-literals-util

Conversation

a0viedo commented Oct 16, 2016

Copy link
Copy Markdown
Member
Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

Util

Description of change

This commit changes string manipulation in favor of template literals in the util module.

nodejs-github-bot added the util Issues and PRs related to the built-in util module. label Oct 16, 2016

mscdex commented Oct 16, 2016

Copy link
Copy Markdown
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/4533/

a0viedo commented Oct 16, 2016

Copy link
Copy Markdown
Member Author

oh the linter was failing for a long line, gonna make that fix once CI finishes

evanlucas commented Oct 17, 2016

Copy link
Copy Markdown
Contributor

I'd be curious to see if this causes any performance regressions in util.format/util.inspect

targos commented Oct 17, 2016

Copy link
Copy Markdown
Member

There should be no change in performance. AFAIK untagged template literals are desugared to string concatenation by V8's parser.

jasnell approved these changes Oct 17, 2016
View reviewed changes

jasnell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

util: use template strings
e668a1a 
This commit changes string manipulation in favor of template literals in the `util` module.

a0viedo commented Oct 17, 2016

Copy link
Copy Markdown
Member Author

Fixed linter.

rvagg force-pushed the master branch 2 times, most recently from c133999 to 83c7a88 Compare October 18, 2016 17:02

jasnell commented Oct 19, 2016

Copy link
Copy Markdown
Member

New CI: https://ci.nodejs.org/job/node-test-pull-request/4577/

jasnell commented Oct 24, 2016

Copy link
Copy Markdown
Member

New CI since the last one was aborted: https://ci.nodejs.org/job/node-test-pull-request/4637/

jasnell pushed a commit that referenced this pull request Oct 26, 2016
util: use template strings
1ee36f6 
This commit changes string manipulation in favor of template
literals in the `util` module.

PR-URL: #9120
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

jasnell commented Oct 26, 2016

Copy link
Copy Markdown
Member

Landed in 1ee36f6

jasnell closed this Oct 26, 2016
evanlucas pushed a commit that referenced this pull request Nov 3, 2016
util: use template strings
4f0596f 
This commit changes string manipulation in favor of template
literals in the `util` module.

PR-URL: #9120
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
evanlucas mentioned this pull request Nov 3, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Nov 22, 2016
util: use template strings
52a04bb 
This commit changes string manipulation in favor of template
literals in the `util` module.

PR-URL: #9120
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 22, 2016
util: use template strings
f18f3b6 
This commit changes string manipulation in favor of template
literals in the `util` module.

PR-URL: #9120
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This was referenced Nov 22, 2016
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
lpinca lpinca approved these changes
+1 more reviewer
targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

util Issues and PRs related to the built-in util module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL